8:18 a.m.
URL: https://github.com/SSSD/sssd/pull/686
Author: pbrezina
Title: #686: nss: use enumeration context as talloc parent for cache req result
Action: opened
PR body:
"""
Otherwise we end up with memory leak since the result is never freed.
Resolves:
https://pagure.io/SSSD/sssd/issue/3870
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/686/head:pr686
git checkout pr686
2:27 p.m.
New subject: [sssd PR#686][comment] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Title: #686: nss: use enumeration context as talloc parent for cache req result
jhrozek commented:
"""
retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/686#issuecomment-434817136
2:28 p.m.
New subject: [sssd PR#686][comment] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Title: #686: nss: use enumeration context as talloc parent for cache req result
jhrozek commented:
"""
I restarted the CI but I suspect the failure is genuine, because I also submitted the same
patch to our internal CI and the runs are (on all systemd) stuck.
"""
See the full comment at https://github.com/SSSD/sssd/pull/686#issuecomment-434817421
6:46 a.m.
New subject: [sssd PR#686][synchronized] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Author: pbrezina
Title: #686: nss: use enumeration context as talloc parent for cache req result
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/686/head:pr686
git checkout pr686
6:47 a.m.
New subject: [sssd PR#686][comment] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Title: #686: nss: use enumeration context as talloc parent for cache req result
pbrezina commented:
"""
`nctx->pwent` and similar were not talloc pointers so sssd crashed. I pushed new
patches.
"""
See the full comment at https://github.com/SSSD/sssd/pull/686#issuecomment-436240470
2:13 a.m.
New subject: [sssd PR#686][+Accepted] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Title: #686: nss: use enumeration context as talloc parent for cache req result
Label: +Accepted
2:13 a.m.
New subject: [sssd PR#686][comment] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Title: #686: nss: use enumeration context as talloc parent for cache req result
jhrozek commented:
"""
Thank you for the explanation, I think this works fine.
"""
See the full comment at https://github.com/SSSD/sssd/pull/686#issuecomment-440947096
3:41 p.m.
New subject: [sssd PR#686][comment] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Title: #686: nss: use enumeration context as talloc parent for cache req result
jhrozek commented:
"""
So far I pushed the patch to master with 406b731ddfbeb62623640cc37a7adc76af0a4b22 but I
suspect we'll do a 1-16 backport later..
"""
See the full comment at https://github.com/SSSD/sssd/pull/686#issuecomment-441123827
3:41 p.m.
New subject: [sssd PR#686][+Pushed] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Title: #686: nss: use enumeration context as talloc parent for cache req result
Label: +Pushed
3:41 p.m.
New subject: [sssd PR#686][closed] nss: use enumeration context as talloc parent for cache req result
URL: https://github.com/SSSD/sssd/pull/686
Author: pbrezina
Title: #686: nss: use enumeration context as talloc parent for cache req result
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/686/head:pr686
git checkout pr686
1987
days inactive
2010
days old
sssd-devel@lists.fedorahosted.org
9 comments
2 participants
participants (2)
-
jhrozek -
pbrezina