URL: https://github.com/SSSD/sssd/pull/267 Author: jhrozek Title: #267: IFP: Resolve group names from GIDs if required Action: opened
PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/3392
The AD provider only converts SIDs to GIDs during initgroups to improve performance. But this is not sufficient for the org.freedesktop.sssd.infopipe.GetUserGroups method, which needs to return names.
We need to resolve the GIDs to names ourselves in that method. In the ticket, @fidencio suggested that solving this might be easier in the cache_req module. We should discuss if this alternative approach makes sense or not, but since I already had these patches, we might as well discuss that in this PR. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/267/head:pr267 git checkout pr267
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
jhrozek commented: """ retest this please """
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-303037343
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
pbrezina commented: """ It can be done in `cache_req` by creating a new module, say `CACHE_REQ_USERGROUPS_BY_NAME/UPN` and by implementing the resolution logic inside `dp_send_fn`. But I think this would be misusing `cache_req` since plugins should have no logic. And implementing it correctly in `cache_req` doesn't really fit in. But it may be separated from the InfoPipe and put into a reusable module. """
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-303384938
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
jhrozek commented: """ On Tue, May 23, 2017 at 05:40:06AM -0700, Pavel Březina wrote:
It can be done in `cache_req` by creating a new module, say `CACHE_REQ_USERGROUPS_BY_NAME/UPN` and by implementing the resolution logic inside `dp_send_fn`. But I think this would be misusing `cache_req` since plugins should have no logic. And implementing it correctly in `cache_req` doesn't really fit in. But it may be separated from the InfoPipe and put into a reusable module.
Sure, I can do that. What about a request in responder_utils.c ?
"""
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-303700437
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
pbrezina commented: """ On 05/24/2017 01:47 PM, Jakub Hrozek wrote:
On Tue, May 23, 2017 at 05:40:06AM -0700, Pavel Březina wrote:
It can be done in `cache_req` by creating a new module, say `CACHE_REQ_USERGROUPS_BY_NAME/UPN` and by implementing the resolution
logic
inside `dp_send_fn`. But I think this would be misusing `cache_req` since plugins should have no logic. And implementing it correctly in `cache_req` doesn't really fit in. But it may be separated from the InfoPipe and put into a reusable module.
Sure, I can do that. What about a request in responder_utils.c ?
Works for me.
"""
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-303709551
URL: https://github.com/SSSD/sssd/pull/267 Author: jhrozek Title: #267: IFP: Resolve group names from GIDs if required Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/267/head:pr267 git checkout pr267
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
jhrozek commented: """ New patches that use a reusable request were pushed """
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-304274657
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/70/28/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-304314814
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
jhrozek commented: """ @pbrezina not trying to be pushy here, but this is something we should get in for the next downstream version, does this patch look better? """
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-304682949
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
pbrezina commented: """ Ack. Sorry for the delay. """
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-305124976
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
lslebodn commented: """ master: * 95acbbb3fbfe972fecd3d8dcbc40d6b1d6b1d354 * c59b7362644efb4546e7fae029b846b53bf48109 * ed15b405ff95e521df3028fc40360a1547ba84bd
"""
See the full comment at https://github.com/SSSD/sssd/pull/267#issuecomment-305175205
URL: https://github.com/SSSD/sssd/pull/267 Author: jhrozek Title: #267: IFP: Resolve group names from GIDs if required Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/267/head:pr267 git checkout pr267
URL: https://github.com/SSSD/sssd/pull/267 Title: #267: IFP: Resolve group names from GIDs if required
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
jhrozek -
lslebodn
-
pbrezina