On (17/06/15 16:26), Nikolai Kondrashov wrote:
Hi everyone,
The attached patch enforces make check failures for the CI coverage build, so
we can catch more test failures.
I think this should also be applied onto sssd-1-12.
NOTE: CI won't pass with this patch ATM, as test_ipa_subdom_server needs to be
fixed first.
Nick
From 14485fbe72ab4c5acaea30899b1dc5bd652e4d36 Mon Sep 17 00:00:00
2001
From: Nikolai Kondrashov <Nikolai.Kondrashov(a)redhat.com>
Date: Wed, 17 Jun 2015 15:13:41 +0300
Subject: [PATCH] CI: Enforce coverage make check failures
Fail CI coverage build, if make-check stage fails. Previously make-check
stage failures were ignored for coverage build for the sake of
collecting coverage data in any case. However, catching extra test
failures seems more important than getting coverage data in all cases,
thus the change.
---
contrib/ci/run | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/contrib/ci/run b/contrib/ci/run
index 5f668ff..e22ed41 100755
--- a/contrib/ci/run
+++ b/contrib/ci/run
@@ -255,6 +255,7 @@ function build_coverage()
{
declare -r coverage_report_dir="ci-report-coverage"
declare test_dir
+ declare status
export CFLAGS="$COVERAGE_CFLAGS"
@@ -271,8 +272,10 @@ function build_coverage()
--base-directory "$BASE_DIR" \
--output-file ci-base.info
# Run tests
- stage make-check make -j $CPU_NUM check || true
+ status=$?
+ stage make-check make -j $CPU_NUM check || status=$?
mv "$test_dir" ci-test-dir
+ ((status == 0))
stage lcov-post lcov --capture --directory . \
--base-directory "$BASE_DIR" \
--
2.1.4
Just for record.
The patch works but need to fix failed test on rhel6.
LS