Just a one-liner but was not exactly easy to find..
On Tue, 2012-03-27 at 15:27 -0400, Jakub Hrozek wrote:
Just a one-liner but was not exactly easy to find..
Nack.
On close inspection, it looks like we're not properly truncating the 'primary_str' variable after this. We're setting the NULL-terminator to be after the asterisk, which is pretty much guaranteed to fail the strncmp() on line 426.
On Thu, Mar 29, 2012 at 02:27:36PM -0400, Stephen Gallagher wrote:
On Tue, 2012-03-27 at 15:27 -0400, Jakub Hrozek wrote:
Just a one-liner but was not exactly easy to find..
Nack.
On close inspection, it looks like we're not properly truncating the 'primary_str' variable after this. We're setting the NULL-terminator to be after the asterisk, which is pretty much guaranteed to fail the strncmp() on line 426.
The strncmp worked because we were only comparing tmp_len-1 bytes and never got to the asterisk. But it's confusing, I fixed the NULL terminator.
On Thu, 2012-03-29 at 15:00 -0400, Jakub Hrozek wrote:
On Thu, Mar 29, 2012 at 02:27:36PM -0400, Stephen Gallagher wrote:
On Tue, 2012-03-27 at 15:27 -0400, Jakub Hrozek wrote:
Just a one-liner but was not exactly easy to find..
Nack.
On close inspection, it looks like we're not properly truncating the 'primary_str' variable after this. We're setting the NULL-terminator to be after the asterisk, which is pretty much guaranteed to fail the strncmp() on line 426.
The strncmp worked because we were only comparing tmp_len-1 bytes and never got to the asterisk. But it's confusing, I fixed the NULL terminator.
Ack for master and sssd-1-8.
On Thu, 2012-03-29 at 15:03 -0400, Stephen Gallagher wrote:
On Thu, 2012-03-29 at 15:00 -0400, Jakub Hrozek wrote:
On Thu, Mar 29, 2012 at 02:27:36PM -0400, Stephen Gallagher wrote:
On Tue, 2012-03-27 at 15:27 -0400, Jakub Hrozek wrote:
Just a one-liner but was not exactly easy to find..
Nack.
On close inspection, it looks like we're not properly truncating the 'primary_str' variable after this. We're setting the NULL-terminator to be after the asterisk, which is pretty much guaranteed to fail the strncmp() on line 426.
The strncmp worked because we were only comparing tmp_len-1 bytes and never got to the asterisk. But it's confusing, I fixed the NULL terminator.
Ack for master and sssd-1-8.
These were pushed to master and sssd-1-8 last week. I forgot to send the email.
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Stephen Gallagher