[PATCH] Make the LOCAL provider always use MagicPrivateGroups

[Stephen Gallagher]

This patch will resolve https://fedorahosted.org/sssd/ticket/95 by
making MPG=false an impossible configuration for the LOCAL provider.

[Stephen Gallagher]

On 08/20/2009 10:34 AM, Stephen Gallagher wrote:
> This patch will resolve https://fedorahosted.org/sssd/ticket/95 by
> making MPG=false an impossible configuration for the LOCAL provider.
>
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Whoops, wrong patch. Correct one attached this time (I hope)

[Sumit Bose]

On Thu, Aug 20, 2009 at 10:50:29AM -0400, Stephen Gallagher wrote:
> On 08/20/2009 10:34 AM, Stephen Gallagher wrote:
> > This patch will resolve https://fedorahosted.org/sssd/ticket/95 by
> > making MPG=false an impossible configuration for the LOCAL provider.
> >
> > sssd-devel mailing list
> > [e-mail]
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
>
> Whoops, wrong patch. Correct one attached this time (I hope)
>
> -- 
> Stephen Gallagher
> RHCE 804006346421761
>
> Looking to carve out IT costs?
> www.redhat.com/carveoutcosts/
> From a080356a3d77a79c487b83282a2e12ed52c77a3d Mon Sep 17 00:00:00 2001
> From: Stephen Gallagher 
> Date: Thu, 20 Aug 2009 10:33:00 -0400
> Subject: [PATCH] Make the LOCAL provider always use MagicPrivateGroups
>
> server/confdb/confdb.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/server/confdb/confdb.c b/server/confdb/confdb.c
> index a44368f..1d75074 100644
> --- a/server/confdb/confdb.c
> +++ b/server/confdb/confdb.c
> @@ -756,7 +756,8 @@ int confdb_get_domain(struct confdb_ctx *cdb,
>      }
>  /* Determine if this is domain uses MPG */
> if (ldb_msg_find_attr_as_bool(res->msgs[0], CONFDB_MPG, 0)) {
> if (strcasecmp(domain->provider, "local") ||
>    ldb_msg_find_attr_as_bool(res->msgs[0], CONFDB_MPG, 0)) {
>    domain->mpg = true;
> }
>
> -- 
> 1.6.2.5

sssd.conf(5) says:
----
magicPrivateGroups (bool)
.....
    Default: FALSE
----

can you add add a hint that for provider=local it will always be TRUE?

bye,
Sumit

[Stephen Gallagher]

On 08/20/2009 10:59 AM, Sumit Bose wrote:
> On Thu, Aug 20, 2009 at 10:50:29AM -0400, Stephen Gallagher wrote:
> > On 08/20/2009 10:34 AM, Stephen Gallagher wrote:
> > > This patch will resolve https://fedorahosted.org/sssd/ticket/95 by
> > > making MPG=false an impossible configuration for the LOCAL provider.
> > >
> > > sssd-devel mailing list
> > > [e-mail]
> > > https://fedorahosted.org/mailman/listinfo/sssd-devel
> >
> > Whoops, wrong patch. Correct one attached this time (I hope)
> >
> > -- 
> > Stephen Gallagher
> > RHCE 804006346421761
> >
> > Looking to carve out IT costs?
> > www.redhat.com/carveoutcosts/
> > From a080356a3d77a79c487b83282a2e12ed52c77a3d Mon Sep 17 00:00:00 2001
> > From: Stephen Gallagher 
> > Date: Thu, 20 Aug 2009 10:33:00 -0400
> > Subject: [PATCH] Make the LOCAL provider always use MagicPrivateGroups
> >
> > server/confdb/confdb.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/server/confdb/confdb.c b/server/confdb/confdb.c
> > index a44368f..1d75074 100644
> > --- a/server/confdb/confdb.c
> > +++ b/server/confdb/confdb.c
> > @@ -756,7 +756,8 @@ int confdb_get_domain(struct confdb_ctx *cdb,
> >      }
> >  /* Determine if this is domain uses MPG */
> > if (ldb_msg_find_attr_as_bool(res->msgs[0], CONFDB_MPG, 0)) {
> > if (strcasecmp(domain->provider, "local") ||
> >    ldb_msg_find_attr_as_bool(res->msgs[0], CONFDB_MPG, 0)) {
> >    domain->mpg = true;
> > }
> >
> > -- 
> > 1.6.2.5
> sssd.conf(5) says:
>
> magicPrivateGroups (bool)
> .....
>     Default: FALSE
>
> can you add add a hint that for provider=local it will always be TRUE?
>
> bye,
> Sumit
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Sorry, didn't think of that. New patch attached.

[Sumit Bose]

On Thu, Aug 20, 2009 at 11:11:22AM -0400, Stephen Gallagher wrote:
> On 08/20/2009 10:59 AM, Sumit Bose wrote:
> > On Thu, Aug 20, 2009 at 10:50:29AM -0400, Stephen Gallagher wrote:
> > > On 08/20/2009 10:34 AM, Stephen Gallagher wrote:
> > > > This patch will resolve https://fedorahosted.org/sssd/ticket/95 by
> > > > making MPG=false an impossible configuration for the LOCAL provider.
>
> Sorry, didn't think of that. New patch attached.

ACK.

bye,
Sumit

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/20/2009 11:34 AM, Sumit Bose wrote:
> On Thu, Aug 20, 2009 at 11:11:22AM -0400, Stephen Gallagher wrote:
> > On 08/20/2009 10:59 AM, Sumit Bose wrote:
> > > On Thu, Aug 20, 2009 at 10:50:29AM -0400, Stephen Gallagher wrote:
> > > > On 08/20/2009 10:34 AM, Stephen Gallagher wrote:
> > > > > This patch will resolve https://fedorahosted.org/sssd/ticket/95 by
> > > > > making MPG=false an impossible configuration for the LOCAL provider.
> >
> > Sorry, didn't think of that. New patch attached.
>
> ACK.
>
> bye,
> Sumit
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkqNemQACgkQeiVVYja6o6NaFgCfebs7kCxrJK+Ni670fT9rPoyj
> GnsAn2R5DG13mJs7jyyjjcuqZ2GXzHQo
> =o7ov
> -----END PGP SIGNATURE-----