[PATCH] fix set last login function in pam handler

[Simo Sorce]

See comments in commit message.
Also add patch to fix some talloc_free -> talloc_zfree cases in sysdb

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Simo Sorce]

On Mon, 2009-10-26 at 15:19 -0400, Simo Sorce wrote:
>  See comments in commit message.
>  Also add patch to fix some talloc_free -> talloc_zfree cases in sysdb 
As discussed on IRC respin to always set PAM_SYSTEM_ERR on error, given
the set_last_login_send request never even have access to the preq->pd
structure much less set pam errors.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/26/2009 03:51 PM, Simo Sorce wrote:
>  On Mon, 2009-10-26 at 15:19 -0400, Simo Sorce wrote:
> > See comments in commit message.
> > Also add patch to fix some talloc_free -> talloc_zfree cases in sysdb
>  
>  As discussed on IRC respin to always set PAM_SYSTEM_ERR on error, given
>  the set_last_login_send request never even have access to the preq->pd
>  structure much less set pam errors.
>  
>  Simo.
>  
>  
>  
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Ack and pushed both patches to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkrl/pEACgkQeiVVYja6o6PwNQCgkAiGjP9kqKpfzjJvfOwQ9l/l
> MqIAoKQl1BoV3XpMt/916QegbpL31HCS
> =DC93
> -----END PGP SIGNATURE-----

[Simo Sorce]

On Mon, 2009-10-26 at 15:55 -0400, Stephen Gallagher wrote:
>  On 10/26/2009 03:51 PM, Simo Sorce wrote:
>  > On Mon, 2009-10-26 at 15:19 -0400, Simo Sorce wrote:
>  >> See comments in commit message.
>  >> Also add patch to fix some talloc_free -> talloc_zfree cases in
>  sysdb
>  > 
>  > As discussed on IRC respin to always set PAM_SYSTEM_ERR on error,
>  given
>  > the set_last_login_send request never even have access to the
>  preq->pd
>  > structure much less set pam errors. 
>  Ack and pushed both patches to master. 
Unfortunately I introduced a different segfault bug with this
patchset :-(

Patch that fixes it attached.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/27/2009 09:26 AM, Simo Sorce wrote:
>  On Mon, 2009-10-26 at 15:55 -0400, Stephen Gallagher wrote:
> > On 10/26/2009 03:51 PM, Simo Sorce wrote:
> >> On Mon, 2009-10-26 at 15:19 -0400, Simo Sorce wrote:
> >>> See comments in commit message.
> >>> Also add patch to fix some talloc_free -> talloc_zfree cases in
> > sysdb
> >>
> >> As discussed on IRC respin to always set PAM_SYSTEM_ERR on error,
> > given
> >> the set_last_login_send request never even have access to the
> > preq->pd
> >> structure much less set pam errors.
>  
> > Ack and pushed both patches to master.
>  
>  Unfortunately I introduced a different segfault bug with this
>  patchset :-(
>  
>  Patch that fixes it attached.
>  
>  Simo.
>  
>  
>  
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Ack and pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkrm9h4ACgkQeiVVYja6o6P0JwCgiUtiXfeCmqwb1bHPqlHlv2XF
> 7TwAoJtNmNuwqAjk6pKn+NQNN6hELwLY
> =lgVu
> -----END PGP SIGNATURE-----