[sssd PR#5498][opened] Covscan fixes

[abbra]

URL: https://github.com/SSSD/sssd/pull/5498
Author: abbra
 Title: #5498: Covscan fixes
Action: opened

PR body:
"""

"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5498/head:pr5498
git checkout pr5498

[sssd PR#5498][+Waiting for review] Covscan fixes

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes

Label: +Waiting for review

[sssd PR#5498][-Waiting for review] Covscan fixes

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes

Label: -Waiting for review

[sssd PR#5498][comment] Covscan fixes

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes

alexey-tikhonov commented:
"""
Hi @abbra,

thanks again for the patches.

I had a couple of minor remarks/questions (please see inline) and just realized that probably you didn't receive a notification for inline comments...
"""

See the full comment at https://github.com/SSSD/sssd/pull/5498#issuecomment-789570599

[sssd PR#5498][comment] Covscan fixes

[abbra]

URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes

abbra commented:
"""
I did receive them but had no time to fix. If you have some time, please feel free to overtake this PR. I don't think I'll have much time until maybe mid March.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5498#issuecomment-789576996

[sssd PR#5498][comment] Covscan fixes

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes

alexey-tikhonov commented:
"""
Hi @abbra,

3 patches were pushed via #5526

This leaves `pam_sss: free env_item when not needed` out but I believe corresponding covscan warning is "false positive" and from my point of view patch isn't entirely correct.

I will close this PR. Please open a new one if you still want to propose [another version of] this patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5498#issuecomment-791462050

[sssd PR#5498][closed] Covscan fixes

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5498
Author: abbra
 Title: #5498: Covscan fixes
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5498/head:pr5498
git checkout pr5498

[sssd PR#5498][comment] Covscan fixes

[abbra]

URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes

abbra commented:
"""
@alexey-tikhonov thanks for handling this. I am OK with dropping the remaining patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5498#issuecomment-792686243