[sssd PR#906][opened] memcache: Stop using the word fastcache for memcache

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
 Title: #906: memcache: Stop using the word fastcache for memcache
Action: opened

PR body:
"""
This patch removes the word fastche from our codebase.

We do not reffer to the fast in-memory mmaped cache consistantly.
Sometimes we call it fastcache, sometimes memcache and sometimes
mmap cache.

While we can not get rid of memcache, because it is rooted
in some config option names and in the documentation and
mmap cache is used a lot internally in our code, so getting
rid of that would require a lot of code changes, we can
easyly get rid of the 'fastcache' word because it is
only in a handful of places.

I think we should really stick to calling it memcache in
the documentation and debug messages and ideally also in
code comments to avoid confusion.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/906/head:pr906
git checkout pr906

[sssd PR#906][comment] memcache: Stop using the word fastcache for memcache

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

mzidek-rh commented:
"""
This is a simple fix, but I think we should not have multiple ways to call one thing in our debug logs and documentation. And thankfully we do not use fastcache on many places.
"""

See the full comment at https://github.com/SSSD/sssd/pull/906#issuecomment-543683234

[sssd PR#906][synchronized] memcache: Stop using the word fastcache for memcache

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
 Title: #906: memcache: Stop using the word fastcache for memcache
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/906/head:pr906
git checkout pr906

[sssd PR#906][comment] memcache: Stop using the word fastcache for memcache

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

mzidek-rh commented:
"""
Fixed some spelling errors in the commit message as per Alexey's feedback.
"""

See the full comment at https://github.com/SSSD/sssd/pull/906#issuecomment-543760623

[sssd PR#906][edited] memcache: Stop using the word fastcache for memcache

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
 Title: #906: memcache: Stop using the word fastcache for memcache
Action: edited

Changed field: body
Original value:
"""
This patch removes the word fastche from our codebase.

We do not reffer to the fast in-memory mmaped cache consistantly.
Sometimes we call it fastcache, sometimes memcache and sometimes
mmap cache.

While we can not get rid of memcache, because it is rooted
in some config option names and in the documentation and
mmap cache is used a lot internally in our code, so getting
rid of that would require a lot of code changes, we can
easyly get rid of the 'fastcache' word because it is
only in a handful of places.

I think we should really stick to calling it memcache in
the documentation and debug messages and ideally also in
code comments to avoid confusion.
"""

[sssd PR#906][comment] memcache: Stop using the word fastcache for memcache

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

alexey-tikhonov commented:
"""
Hi @mzidek-rh,
> I think we should really stick to calling it memcache in
> the documentation and debug messages

Does

(1) man/sssd.8.xml: " ... client applications will not use the fast in memory cache."

and

(2) tools/tools_mc_util.c: ERROR("The fast memory caches was not invalidated by NSS "

fit your intention well?
"""

See the full comment at https://github.com/SSSD/sssd/pull/906#issuecomment-543764808

[sssd PR#906][synchronized] memcache: Stop using the word fastcache for memcache

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
 Title: #906: memcache: Stop using the word fastcache for memcache
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/906/head:pr906
git checkout pr906

[sssd PR#906][comment] memcache: Stop using the word fastcache for memcache

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

mzidek-rh commented:
"""
(1) man/sssd.8.xml: " ... client applications will not use the fast in memory cache."

This one is ok. The fast in-memory cache is what memcache is, so it is not confusing and it is obvious that it is about memcache because the option name is memcache_timeout. I just fixed the typo (missing "-").

(2) tools/tools_mc_util.c: ERROR("The fast memory caches was not invalidated by NSS "

Here it could be confusing. I will changed it to memcache. Good catch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/906#issuecomment-543783986

[sssd PR#906][comment] memcache: Stop using the word fastcache for memcache

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

mzidek-rh commented:
"""
(1) man/sssd.8.xml: " ... client applications will not use the fast in memory cache."

This one is ok. The fast in-memory cache is what memcache is, so it is not confusing and it is obvious that it is about memcache because the option name is memcache_timeout. I just fixed the typo (missing "-").

(2) tools/tools_mc_util.c: ERROR("The fast memory caches was not invalidated by NSS "

Here it could be confusing. I changed it to memcache. Good catch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/906#issuecomment-543783986

[sssd PR#906][comment] memcache: Stop using the word fastcache for memcache

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

alexey-tikhonov commented:
"""
ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/906#issuecomment-543786192

[sssd PR#906][+Accepted] memcache: Stop using the word fastcache for memcache

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

Label: +Accepted

[sssd PR#906][+Ready to push] memcache: Stop using the word fastcache for memcache

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

Label: +Ready to push

[sssd PR#906][comment] memcache: Stop using the word fastcache for memcache

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

pbrezina commented:
"""
* `master`
    * 53d4393e6db76cdcd16109faf0fd92d2fa617760 - memcache: Stop using the word fastcache for memcache

"""

See the full comment at https://github.com/SSSD/sssd/pull/906#issuecomment-544426031

[sssd PR#906][+Pushed] memcache: Stop using the word fastcache for memcache

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

Label: +Pushed

[sssd PR#906][-Accepted] memcache: Stop using the word fastcache for memcache

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

Label: -Accepted

[sssd PR#906][-Ready to push] memcache: Stop using the word fastcache for memcache

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache

Label: -Ready to push

[sssd PR#906][closed] memcache: Stop using the word fastcache for memcache

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
 Title: #906: memcache: Stop using the word fastcache for memcache
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/906/head:pr906
git checkout pr906