[sssd PR#891][opened] IPA: Utilize new protocol in IPA extdom plugin

[thalman]

URL: https://github.com/SSSD/sssd/pull/891
Author: thalman
 Title: #891: IPA: Utilize new protocol in IPA extdom plugin
Action: opened

PR body:
"""
To allow @-sign in group name IPA extdom plugin had to be
extended. Now the protocol distinguishes between resolving
username and groupname.

Until now name resolution was performed as it is a user and
in case of not finding any user, group search was performed.
But the SSSD knows the type of object, that is resolved.

This change will improve the performance of the system.

The @-sign issue is completely fixed on IPA side and
will work for older clients too.

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1383520
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/891/head:pr891
git checkout pr891

[sssd PR#891][synchronized] IPA: Utilize new protocol in IPA extdom plugin

[thalman]

URL: https://github.com/SSSD/sssd/pull/891
Author: thalman
 Title: #891: IPA: Utilize new protocol in IPA extdom plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/891/head:pr891
git checkout pr891

[sssd PR#891][+Waiting for review] IPA: Utilize new protocol in IPA extdom plugin

[thalman]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: +Waiting for review

[sssd PR#891][comment] IPA: Utilize new protocol in IPA extdom plugin

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

sumit-bose commented:
"""
Hi,

(sorry for the delay), please see my inline comment.

With the fix from the comment that patch is working well and as expected with IPA servers with and without the new OID and Coverity didn't found an issue as well.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/891#issuecomment-551035585

[sssd PR#891][-Waiting for review] IPA: Utilize new protocol in IPA extdom plugin

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: -Waiting for review

[sssd PR#891][+Changes requested] IPA: Utilize new protocol in IPA extdom plugin

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: +Changes requested

[sssd PR#891][synchronized] IPA: Utilize new protocol in IPA extdom plugin

[thalman]

URL: https://github.com/SSSD/sssd/pull/891
Author: thalman
 Title: #891: IPA: Utilize new protocol in IPA extdom plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/891/head:pr891
git checkout pr891

[sssd PR#891][synchronized] IPA: Utilize new protocol in IPA extdom plugin

[thalman]

URL: https://github.com/SSSD/sssd/pull/891
Author: thalman
 Title: #891: IPA: Utilize new protocol in IPA extdom plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/891/head:pr891
git checkout pr891

[sssd PR#891][comment] IPA: Utilize new protocol in IPA extdom plugin

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

sumit-bose commented:
"""
Thanks, ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/891#issuecomment-551822246

[sssd PR#891][+Accepted] IPA: Utilize new protocol in IPA extdom plugin

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: +Accepted

[sssd PR#891][-Changes requested] IPA: Utilize new protocol in IPA extdom plugin

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: -Changes requested

[sssd PR#891][+Ready to push] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: +Ready to push

[sssd PR#891][comment] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

pbrezina commented:
"""
@thalman Can you please reference an upstream ticket instead of bugzilla? Is it [this ticket](https://pagure.io/SSSD/sssd/issue/3219)? Can it be closed now?
"""

See the full comment at https://github.com/SSSD/sssd/pull/891#issuecomment-553779903

[sssd PR#891][-Ready to push] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: -Ready to push

[sssd PR#891][synchronized] IPA: Utilize new protocol in IPA extdom plugin

[thalman]

URL: https://github.com/SSSD/sssd/pull/891
Author: thalman
 Title: #891: IPA: Utilize new protocol in IPA extdom plugin
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/891/head:pr891
git checkout pr891

[sssd PR#891][edited] IPA: Utilize new protocol in IPA extdom plugin

[thalman]

URL: https://github.com/SSSD/sssd/pull/891
Author: thalman
 Title: #891: IPA: Utilize new protocol in IPA extdom plugin
Action: edited

Changed field: body
Original value:
"""
To allow @-sign in group name IPA extdom plugin had to be
extended. Now the protocol distinguishes between resolving
username and groupname.

Until now name resolution was performed as it is a user and
in case of not finding any user, group search was performed.
But the SSSD knows the type of object, that is resolved.

This change will improve the performance of the system.

The @-sign issue is completely fixed on IPA side and
will work for older clients too.

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1383520
"""

[sssd PR#891][comment] IPA: Utilize new protocol in IPA extdom plugin

[thalman]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

thalman commented:
"""
> @thalman Can you please reference an upstream ticket instead of bugzilla? Is it [this ticket](https://pagure.io/SSSD/sssd/issue/3219)? Can it be closed now?

@pbrezina thanks,
reference updated in commit message as well as in PR description, [this ticket](https://pagure.io/SSSD/sssd/issue/3219) can be closed

"""

See the full comment at https://github.com/SSSD/sssd/pull/891#issuecomment-553795607

[sssd PR#891][comment] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

pbrezina commented:
"""
Thank you. I'm going to push it since you did not touch the patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/891#issuecomment-553825415

[sssd PR#891][+Ready to push] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: +Ready to push

[sssd PR#891][comment] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

pbrezina commented:
"""
* `master`
    * 469f1acd6d001cde941cb14d2f15c1b1093fe285 - IPA: Utilize new protocol in IPA extdom plugin

"""

See the full comment at https://github.com/SSSD/sssd/pull/891#issuecomment-553825994

[sssd PR#891][+Pushed] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: +Pushed

[sssd PR#891][-Accepted] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: -Accepted

[sssd PR#891][-Ready to push] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Title: #891: IPA: Utilize new protocol in IPA extdom plugin

Label: -Ready to push

[sssd PR#891][closed] IPA: Utilize new protocol in IPA extdom plugin

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/891
Author: thalman
 Title: #891: IPA: Utilize new protocol in IPA extdom plugin
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/891/head:pr891
git checkout pr891