[PATCH] Eliminate unnecessary explicit timeout for DP account requests

[Stephen Gallagher]

D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if
a timeout fires, so we can rely on this instead of having an
explicit timeout ourselves. Furthermore, the two timeouts present
a potential race condition.
-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

[Stephen Gallagher]

On 08/12/2009 08:51 AM, Stephen Gallagher wrote:
>  D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if
>  a timeout fires, so we can rely on this instead of having an
>  explicit timeout ourselves. Furthermore, the two timeouts present
>  a potential race condition.
>  
>  
>  ------------------------------------------------------------------------
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Patch was nacked on IRC. I forgot to take advantage of the 'timeout'
argument passed in.

New patch attached.

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

[Simo Sorce]

On Wed, 2009-08-12 at 09:04 -0400, Stephen Gallagher wrote:
>  On 08/12/2009 08:51 AM, Stephen Gallagher wrote:
>  > D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if
>  > a timeout fires, so we can rely on this instead of having an
>  > explicit timeout ourselves. Furthermore, the two timeouts present
>  > a potential race condition. 
>  Patch was nacked on IRC. I forgot to take advantage of the
> 'timeout'
>  argument passed in.
>  
>  New patch attached.
>   
remove also the tevent_timer structure from ndp_req and it is a ack :-)

Simo.

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/12/2009 09:09 AM, Simo Sorce wrote:
>  On Wed, 2009-08-12 at 09:04 -0400, Stephen Gallagher wrote:
> > On 08/12/2009 08:51 AM, Stephen Gallagher wrote:
> >> D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if
> >> a timeout fires, so we can rely on this instead of having an
> >> explicit timeout ourselves. Furthermore, the two timeouts present
> >> a potential race condition.
>  
> > Patch was nacked on IRC. I forgot to take advantage of the 'timeout'
> > argument passed in.
> >
> > New patch attached.
> >
>  
>  remove also the tevent_timer structure from ndp_req and it is a ack :-)
>  
>  Simo.
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Fixed and pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkqCv/IACgkQeiVVYja6o6OjdwCdFfS4ZZ/DDKbhJVLR2OQUUfp6
> C/4An1yf8pDt2zZ5eg6RYrSy7nONLqDN
> =KwA5
> -----END PGP SIGNATURE-----