D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if a timeout fires, so we can rely on this instead of having an explicit timeout ourselves. Furthermore, the two timeouts present a potential race condition.
On 08/12/2009 08:51 AM, Stephen Gallagher wrote:
D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if a timeout fires, so we can rely on this instead of having an explicit timeout ourselves. Furthermore, the two timeouts present a potential race condition.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
Patch was nacked on IRC. I forgot to take advantage of the 'timeout' argument passed in.
New patch attached.
On Wed, 2009-08-12 at 09:04 -0400, Stephen Gallagher wrote:
On 08/12/2009 08:51 AM, Stephen Gallagher wrote:
D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if a timeout fires, so we can rely on this instead of having an explicit timeout ourselves. Furthermore, the two timeouts present a potential race condition.
Patch was nacked on IRC. I forgot to take advantage of the 'timeout' argument passed in.
New patch attached.
remove also the tevent_timer structure from ndp_req and it is a ack :-)
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 08/12/2009 09:09 AM, Simo Sorce wrote:
On Wed, 2009-08-12 at 09:04 -0400, Stephen Gallagher wrote:
On 08/12/2009 08:51 AM, Stephen Gallagher wrote:
D-BUS handles timeouts itself and reports DBUS_ERROR_NO_REPLY if a timeout fires, so we can rely on this instead of having an explicit timeout ourselves. Furthermore, the two timeouts present a potential race condition.
Patch was nacked on IRC. I forgot to take advantage of the 'timeout' argument passed in.
New patch attached.
remove also the tevent_timer structure from ndp_req and it is a ack :-)
Simo.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
Fixed and pushed to master.
- -- Stephen Gallagher RHCE 804006346421761
Looking to carve out IT costs? www.redhat.com/carveoutcosts/
sssd-devel@lists.fedorahosted.org
-
Simo Sorce -
Stephen Gallagher