[PATCH] Ensure that SSSD shuts down completely before restarting

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I think this finally solves:
https://bugzilla.redhat.com/show_bug.cgi?id=606887

killproc only sends SIGTERM, but doesn't check whether the process
actually exited before returning success. So we were trying to start up
a new SSSD process before the previous one had fully shut down.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkzj2nEACgkQeiVVYja6o6NsfACfaHXO+5z0iwjBqipQUc5YEFMk
> GW4AoJImxpFJc61WssedmRvPSC0Cwn9z
> =gNKu
> -----END PGP SIGNATURE-----

[Sumit Bose]

On Wed, Nov 17, 2010 at 08:36:54AM -0500, Stephen Gallagher wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>  
>  I think this finally solves:
>  https://bugzilla.redhat.com/show_bug.cgi?id=606887
>  
>  killproc only sends SIGTERM, but doesn't check whether the process
>  actually exited before returning success. So we were trying to start up
>  a new SSSD process before the previous one had fully shut down.
>   
ACK

bye,
Sumit

>  - -- 
>  Stephen Gallagher
>  RHCE 804006346421761
>  
>  Delivering value year after year.
>  Red Hat ranks #1 in value among software vendors.
>  http://www.redhat.com/promo/vendor/
>  -----BEGIN PGP SIGNATURE-----
>  Version: GnuPG v1.4.11 (GNU/Linux)
>  Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>  
>  iEYEARECAAYFAkzj2nEACgkQeiVVYja6o6NsfACfaHXO+5z0iwjBqipQUc5YEFMk
>  GW4AoJImxpFJc61WssedmRvPSC0Cwn9z
>  =gNKu
>  -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/17/2010 04:37 PM, Sumit Bose wrote:
>  On Wed, Nov 17, 2010 at 08:36:54AM -0500, Stephen Gallagher wrote:
>  I think this finally solves:
>  https://bugzilla.redhat.com/show_bug.cgi?id=606887
>  
>  killproc only sends SIGTERM, but doesn't check whether the process
>  actually exited before returning success. So we were trying to start up
>  a new SSSD process before the previous one had fully shut down.
>  
>  
> > ACK
>   
Pushed to master
- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkzlMQUACgkQeiVVYja6o6PcqACgoYQXUdC2gdSbgPxd4y3fz45z
> fNsAn1gQVoJcUkoruA0B+KtiiJSbBEYe
> =uT82
> -----END PGP SIGNATURE-----

[Jeff Schroeder]

On Thu, Nov 18, 2010 at 5:58 AM, Stephen Gallagher <sgallagh(a)redhat.com&gt; wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>
>  On 11/17/2010 04:37 PM, Sumit Bose wrote:
> > On Wed, Nov 17, 2010 at 08:36:54AM -0500, Stephen Gallagher wrote:
> > I think this finally solves:
> > https://bugzilla.redhat.com/show_bug.cgi?id=606887
> >
> > killproc only sends SIGTERM, but doesn't check whether the process
> > actually exited before returning success. So we were trying to start up
> > a new SSSD process before the previous one had fully shut down.
> >
> >
> >> ACK
> >
>
>  Pushed to master
>  - --
>  Stephen Gallagher 
Will this be added to sssd-1.2 as well or is 1.5 going to soon be the
next "stable" release?

-- 
Jeff Schroeder

Don't drink and derive, alcohol and analysis don't mix.
http://www.digitalprognosis.com

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/18/2010 09:17 AM, Jeff Schroeder wrote:
>  On Thu, Nov 18, 2010 at 5:58 AM, Stephen Gallagher
> <sgallagh(a)redhat.com&gt; wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 11/17/2010 04:37 PM, Sumit Bose wrote:
> >> On Wed, Nov 17, 2010 at 08:36:54AM -0500, Stephen Gallagher wrote:
> >> I think this finally solves:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=606887
> >>
> >> killproc only sends SIGTERM, but doesn't check whether the process
> >> actually exited before returning success. So we were trying to start up
> >> a new SSSD process before the previous one had fully shut down.
> >>
> >>
> >>> ACK
> >>
> >
> > Pushed to master
> > - --
> > Stephen Gallagher
>  
>  Will this be added to sssd-1.2 as well or is 1.5 going to soon be the
>  next "stable" release?
>   
This patch only makes changes to the SysV init script that hasn't
changed between 1.2 and 1.5, so it would be trivial to cherry-pick this
into 1.2.


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkzlNhMACgkQeiVVYja6o6PrWwCfTzwHs/Ru4cgaOho95nuuyghF
> nf8Anjq7e+Dh2J/U6kZQg2i727PpENjE
> =MDOx
> -----END PGP SIGNATURE-----