URL: https://github.com/SSSD/sssd/pull/741 Author: alexey-tikhonov Title: #741: sbus/interface: fixed interface copy helpers Action: opened
PR body: """ In `sbus_method_copy()` and other copy helpers there was code like: ``` copy = talloc_zero_array(mem_ctx, struct sbus_method, count + 1); memcpy(copy, input, sizeof(struct sbus_method) * count + 1); ``` Copy of one byte of "sentinel" doesn't make a sense. We can either rely on the fact that sentinel is zero-initialized struct *and* `talloc_zero_array()` zero-initializes memory (so copying of sentinel may be omitted at all) or just copy sentinel in a whole. Opted for second option as more clear variant. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/741/head:pr741 git checkout pr741
URL: https://github.com/SSSD/sssd/pull/741 Title: #741: sbus/interface: fixed interface copy helpers
pbrezina commented: """ Ack. Thank you. """
See the full comment at https://github.com/SSSD/sssd/pull/741#issuecomment-460551869
URL: https://github.com/SSSD/sssd/pull/741 Title: #741: sbus/interface: fixed interface copy helpers
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/741 Title: #741: sbus/interface: fixed interface copy helpers
jhrozek commented: """ * master: 38ebae7e0ea889fa9022670a3e08e7352b624677 """
See the full comment at https://github.com/SSSD/sssd/pull/741#issuecomment-460802233
URL: https://github.com/SSSD/sssd/pull/741 Author: alexey-tikhonov Title: #741: sbus/interface: fixed interface copy helpers Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/741/head:pr741 git checkout pr741
URL: https://github.com/SSSD/sssd/pull/741 Title: #741: sbus/interface: fixed interface copy helpers
Label: +Pushed
sssd-devel@lists.fedorahosted.org