9:38 a.m.
URL: https://github.com/SSSD/sssd/pull/932
Author: alexey-tikhonov
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Action: opened
PR body:
"""
The following flow was causing use-after-free error:
tevent_common_invoke_fd_handler(RW) -> sbus_watch_handler(RW) ->
dbus_watch_handle(R) -> ...libdbus detects connection is closed... ->
sbus_remove_watch() -> talloc_free(watch) ->
... get back to libdbus and back to sbus_watch_handler() ->
"if (watch->dbus_write_watch) dbus_watch_handle(W)" => use-after-free
To resolve an issue schedule deallocation of watch as immediate event.
Resolves: https://pagure.io/SSSD/sssd/issue/2660
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/932/head:pr932
git checkout pr932
12:03 p.m.
New subject: [sssd PR#932][+Waiting for review] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: +Waiting for review
7:30 a.m.
New subject: [sssd PR#932][-Waiting for review] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: -Waiting for review
10:31 a.m.
New subject: [sssd PR#932][synchronized] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Author: alexey-tikhonov
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/932/head:pr932
git checkout pr932
10:34 a.m.
New subject: [sssd PR#932][synchronized] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Author: alexey-tikhonov
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/932/head:pr932
git checkout pr932
11:22 a.m.
New subject: [sssd PR#932][+Waiting for review] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: +Waiting for review
3:45 a.m.
New subject: [sssd PR#932][comment] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
pbrezina commented:
"""
LGTM, just please use `talloc_zfree` instead of `TALLOC_FREE`.
"""
See the full comment at https://github.com/SSSD/sssd/pull/932#issuecomment-555925012
3:55 a.m.
New subject: [sssd PR#932][-Waiting for review] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: -Waiting for review
3:56 a.m.
New subject: [sssd PR#932][+Changes requested] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: +Changes requested
6:24 a.m.
New subject: [sssd PR#932][synchronized] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Author: alexey-tikhonov
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/932/head:pr932
git checkout pr932
6:25 a.m.
New subject: [sssd PR#932][comment] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
alexey-tikhonov commented:
"""
LGTM, just please use `talloc_zfree` instead of `TALLOC_FREE`.
Thanks for the catch. I have missed this while replicating changes from the twin PR
#934.
Fixed.
"""
See the full comment at https://github.com/SSSD/sssd/pull/932#issuecomment-555982321
6:26 a.m.
New subject: [sssd PR#932][+Waiting for review] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: +Waiting for review
6:26 a.m.
New subject: [sssd PR#932][-Changes requested] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: -Changes requested
6:34 a.m.
New subject: [sssd PR#932][comment] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
pbrezina commented:
"""
Ack. I will postpone pushing it until we have some information from the customer.
"""
See the full comment at https://github.com/SSSD/sssd/pull/932#issuecomment-555984989
6:34 a.m.
New subject: [sssd PR#932][-Waiting for review] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: -Waiting for review
6:34 a.m.
New subject: [sssd PR#932][+Deferred] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: +Deferred
6:34 a.m.
New subject: [sssd PR#932][+Accepted] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: +Accepted
4:20 a.m.
New subject: [sssd PR#932][-Deferred] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: -Deferred
4:20 a.m.
New subject: [sssd PR#932][+Ready to push] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: +Ready to push
4:21 a.m.
New subject: [sssd PR#932][comment] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
pbrezina commented:
"""
Customer did not report any issue in two weeks.
"""
See the full comment at https://github.com/SSSD/sssd/pull/932#issuecomment-559025080
4:23 a.m.
New subject: [sssd PR#932][comment] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
pbrezina commented:
"""
* `sssd-1-16`
* f845355e32127c5e8f2bf700cdaa5b8721804232 - SBUS: defer deallocation of
sbus_watch_ctx
"""
See the full comment at https://github.com/SSSD/sssd/pull/932#issuecomment-559026081
4:23 a.m.
New subject: [sssd PR#932][+Pushed] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: +Pushed
4:23 a.m.
New subject: [sssd PR#932][-Accepted] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: -Accepted
4:23 a.m.
New subject: [sssd PR#932][-Ready to push] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Label: -Ready to push
4:23 a.m.
New subject: [sssd PR#932][closed] SBUS: defer deallocation of sbus_watch_ctx
URL: https://github.com/SSSD/sssd/pull/932
Author: alexey-tikhonov
Title: #932: SBUS: defer deallocation of sbus_watch_ctx
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/932/head:pr932
git checkout pr932
1612
days inactive
1628
days old
sssd-devel@lists.fedorahosted.org
24 comments
2 participants
participants (2)
-
alexey-tikhonov -
pbrezina