URL: https://github.com/SSSD/sssd/pull/1003 Author: alexey-tikhonov Title: #1003: Watchdog: fixes "off-by-one" error Action: opened
PR body: """ 'man sssd.conf': timeout: "Note that after three missed heartbeats the process will terminate itself."
But implementation was: ``` #define WATCHDOG_MAX_TICKS 3 ... if (__sync_add_and_fetch(&watchdog_ctx.ticks, 1) > WATCHDOG_MAX_TICKS) { ... _exit(1); ``` -- since after reset ticks start from 0 effectively this was 4 heartbeats.
Fixed to match man page.
Resolves: https://pagure.io/SSSD/sssd/issue/4169 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1003/head:pr1003 git checkout pr1003
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
Label: +branch: sssd-1-16
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
pbrezina commented: """ Thank you. Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/1003#issuecomment-600135970
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
pbrezina commented: """ * `master` * 653df698a7a04c40df13eb4217c7d598aba8f8f8 - Watchdog: fixes "off-by-one" error * `sssd-1-16` * b46e2d4e3b150984bc6e3d74fbbaf215c7b728e3 - Watchdog: fixes "off-by-one" error
"""
See the full comment at https://github.com/SSSD/sssd/pull/1003#issuecomment-600593084
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/1003 Title: #1003: Watchdog: fixes "off-by-one" error
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/1003 Author: alexey-tikhonov Title: #1003: Watchdog: fixes "off-by-one" error Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1003/head:pr1003 git checkout pr1003
sssd-devel@lists.fedorahosted.org