5:50 a.m.
URL: https://github.com/SSSD/sssd/pull/863
Author: pbrezina
Title: #863: ci: add Debian 10
Action: opened
PR body:
"""
None
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/863/head:pr863
git checkout pr863
9:07 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
jhrozek commented:
"""
Hi @pbrezina I would prefer if @alexey-tikhonov could check the valgrind errors, because
he was already looking into them. Honestly they seem a bit too much like a black check :-)
maybe Alexey would know how to make them more specific to the location of the error.
Anyway, great job. One step closer to retiring the old CI :-)
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-519933107
5:28 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
It seems there is some ssh problem with the box.
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-520372457
9:14 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
alexey-tikhonov commented:
"""
I would prefer if @alexey-tikhonov could check the valgrind errors
Is it possible limit scope of some suppression patterns to specific OS?
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-521263677
6:36 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
I do not think so. We might concatenate several distro-specific suppresion files into one
and feed this to valgrind but that would be quite tedious work.
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-522531413
6:36 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
The ssh error is fixed with new box.
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-522531656
8:10 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
SSH issue happend again with respin of the box. Need to find why.
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-523449949
5:52 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
Ok, Debian box is now working. I opened a
[bug](https://bugzilla.redhat.com/show_bug.cgi?id=1748821) against vagrant and workaround
it like
[this](https://github.com/SSSD/sssd-test-suite/commit/8206de10b5540866afc7....
@alexey-tikhonov do you have some comments?
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-529414704
5:53 a.m.
New subject: [sssd PR#863][+Waiting for review] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +Waiting for review
8:04 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
alexey-tikhonov commented:
"""
@alexey-tikhonov do you have some comments?
From my point of view, this patch of suppression patterns is quite evil.
Do we have any means to track update of Debian's openssl to remove this patch later
(when Debian will get openssl fixed)?
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-529463747
3:23 a.m.
New subject: [sssd PR#863][-Waiting for review] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: -Waiting for review
3:24 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
I will check what can we do in this area.
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-530721082
9:14 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
alexey-tikhonov commented:
"""
I do not think so. We might concatenate several distro-specific
suppresion files into one and feed this to valgrind but that would be quite tedious work.
If I understand correctly, there is no need to concatenate files into one. According to
the man page: "You may use up to 100 extra suppression files."
Would it be possible to add to the `stage make-check-valgrind` something like:
```
--suppressions=\"$CI_DIR/$DISTRO_SPECIFIC.SUPP\" \
```
and define this var depending on distro?
We could have those "addons" empty for all distros but Debian and to place
supp-patch there.
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-530845614
3:13 a.m.
New subject: [sssd PR#863][+Changes requested] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +Changes requested
3:14 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
Sounds good. I will do that.
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-531144525
6:16 a.m.
New subject: [sssd PR#863][synchronized] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Author: pbrezina
Title: #863: ci: add Debian 10
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/863/head:pr863
git checkout pr863
7:22 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
@alexey-tikhonov How about now?
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-531753529
7:22 a.m.
New subject: [sssd PR#863][-Changes requested] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: -Changes requested
7:22 a.m.
New subject: [sssd PR#863][+Waiting for review] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +Waiting for review
9:06 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-531792891
10:09 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
alexey-tikhonov commented:
"""
@alexey-tikhonov How about now?
Thank you, LGTM. ACK.
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-531821067
10:09 a.m.
New subject: [sssd PR#863][+Accepted] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +Accepted
10:09 a.m.
New subject: [sssd PR#863][-Waiting for review] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: -Waiting for review
7:36 a.m.
New subject: [sssd PR#863][+Ready to push] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +Ready to push
7:45 a.m.
New subject: [sssd PR#863][+branch: sssd-1-16] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +branch: sssd-1-16
7:46 a.m.
New subject: [sssd PR#863][+Conflict] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +Conflict
7:46 a.m.
New subject: [sssd PR#863][-Ready to push] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: -Ready to push
7:47 a.m.
New subject: [sssd PR#863][-Conflict] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: -Conflict
7:47 a.m.
New subject: [sssd PR#863][-branch: sssd-1-16] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: -branch: sssd-1-16
7:47 a.m.
New subject: [sssd PR#863][+Ready to push] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +Ready to push
7:47 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
* `master`
* 206d994ed91dffeb631fc030b89cba20b95cbf28 - ci: add Debian 10
* 4488908f527927ad3539a3cf20726ab3e0e1fc36 - ci: suppress Debian valgrind errors
* b241e079051056e100010bba7d4952867fe42ddb - ci: allow distribution specific
supression files
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-532205095
7:48 a.m.
New subject: [sssd PR#863][+Pushed] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: +Pushed
7:48 a.m.
New subject: [sssd PR#863][-Accepted] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: -Accepted
7:48 a.m.
New subject: [sssd PR#863][-Ready to push] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
Label: -Ready to push
7:48 a.m.
New subject: [sssd PR#863][closed] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Author: pbrezina
Title: #863: ci: add Debian 10
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/863/head:pr863
git checkout pr863
7:54 a.m.
New subject: [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Title: #863: ci: add Debian 10
pbrezina commented:
"""
* `master`
* 206d994ed91dffeb631fc030b89cba20b95cbf28 - ci: add Debian 10
* 4488908f527927ad3539a3cf20726ab3e0e1fc36 - ci: suppress Debian valgrind errors
* b241e079051056e100010bba7d4952867fe42ddb - ci: allow distribution specific
supression files
* `sssd-1-16`
* 5157fccfd87261f966aa004ba5e3168f3417c0ce - ci: add Debian 10
* c8a4c8e2eadb7c123e87d9edd3c2124681dc30fd - ci: suppress Debian valgrind errors
* 6b2c9e822c01e4f7606d9585e7beb87762c77229 - ci: allow distribution specific supression
files
"""
See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-532205095
1682
days inactive
1721
days old
sssd-devel@lists.fedorahosted.org
35 comments
3 participants
participants (3)
-
alexey-tikhonov -
jhrozek
-
pbrezina