[sssd PR#598][opened] intg: Do not hardcode nsslibdir

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/598
Author: fidencio
 Title: #598: intg: Do not hardcode nsslibdir
Action: opened

PR body:
"""
This change is needed in order to have make intgcheck-run properly
running on opensuse systems.

CI: http://vm-031.${abc}/logs/job/90/35/summary.html

"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/598/head:pr598
git checkout pr598

[sssd PR#598][comment] intg: Do not hardcode nsslibdir

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

jhrozek commented:
"""
Hi @ChrisKowalczyk, I wonder if you had time to try if this patch helps you to run the
test?

In the meantime, @mzidek-rh would review as well, but it would be nice to see if Chris is
unblocked.
"""

See the full comment at https://github.com/SSSD/sssd/pull/598#issuecomment-397029608

[sssd PR#598][comment] intg: Do not hardcode nsslibdir

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

fidencio commented:
"""
@jhrozek, @mzidek-rh,

This solved my issue on my Leap15.0 box but @ChrisKowalczyk is still facing issues. We
will have a tmate session + phone talk Tomorrow in order to get it solved. There's no
need to review this PR till we solve it from @ChrisKowalczyk's side.
"""

See the full comment at https://github.com/SSSD/sssd/pull/598#issuecomment-397038246

[sssd PR#598][comment] intg: Do not hardcode nsslibdir

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

fidencio commented:
"""
So, the tmate session + phone talk happened this morning and the patch does fix the issues
both @ChrisKowalczyk and myself faced on Leap 15.0.

@mzidek-rh, please, feel free to review this PR. :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/598#issuecomment-397209140

[sssd PR#598][comment] intg: Do not hardcode nsslibdir

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

mzidek-rh commented:
"""
@fidencio Thanks for the info. I will try to do the review before today's call.
"""

See the full comment at https://github.com/SSSD/sssd/pull/598#issuecomment-397219141

[sssd PR#598][comment] intg: Do not hardcode nsslibdir

[ChrisKowalczyk]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

ChrisKowalczyk commented:
"""
@mzidek-rh , @fidencio , @jhrozek , yes, I re-run everything again by myself and I can
confirm that PR works as expected. Thanks guys!
"""

See the full comment at https://github.com/SSSD/sssd/pull/598#issuecomment-397222102

[sssd PR#598][comment] intg: Do not hardcode nsslibdir

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

mzidek-rh commented:
"""
The patch looks good. Just waiting for the CI to finish.
"""

See the full comment at https://github.com/SSSD/sssd/pull/598#issuecomment-397234926

[sssd PR#598][comment] intg: Do not hardcode nsslibdir

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

mzidek-rh commented:
"""
The CI passed. ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/598#issuecomment-397608091

[sssd PR#598][+Accepted] intg: Do not hardcode nsslibdir

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

Label: +Accepted

[sssd PR#598][comment] intg: Do not hardcode nsslibdir

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

fidencio commented:
"""
master:
 b34fcff
"""

See the full comment at https://github.com/SSSD/sssd/pull/598#issuecomment-397796757

[sssd PR#598][closed] intg: Do not hardcode nsslibdir

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/598
Author: fidencio
 Title: #598: intg: Do not hardcode nsslibdir
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/598/head:pr598
git checkout pr598

[sssd PR#598][-Accepted] intg: Do not hardcode nsslibdir

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

Label: -Accepted

[sssd PR#598][+Pushed] intg: Do not hardcode nsslibdir

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/598
Title: #598: intg: Do not hardcode nsslibdir

Label: +Pushed