Patch 0001: Make SSSDConfig a package We were polluting the primary Python space with several dependencies. We will now install them their own directory/module. This has been done in such a way that existing scripts that import SSSDConfig will require no modifications.
Patch 0002: Make default config and schema file locations configurable Previously, we were hard-coding the sssd.conf and sssd.api.* locations into the source. With this patch, we will take the default locations from values specified by autoconf.
On Fri, May 18, 2012 at 09:28:20AM -0400, Stephen Gallagher wrote:
Patch 0001: Make SSSDConfig a package We were polluting the primary Python space with several dependencies. We will now install them their own directory/module. This has been done in such a way that existing scripts that import SSSDConfig will require no modifications.
Patch 0002: Make default config and schema file locations configurable Previously, we were hard-coding the sssd.conf and sssd.api.* locations into the source. With this patch, we will take the default locations from values specified by autoconf.
I'm seeing:
ERROR: files left in build directory after distclean: ./src/config/SSSDConfig/ipachangeconf.py ./src/config/SSSDConfig/sssd_upgrade_config.py
When running make distcheck.
On Mon, 2012-05-21 at 11:36 +0200, Jakub Hrozek wrote:
On Fri, May 18, 2012 at 09:28:20AM -0400, Stephen Gallagher wrote:
Patch 0001: Make SSSDConfig a package We were polluting the primary Python space with several dependencies. We will now install them their own directory/module. This has been done in such a way that existing scripts that import SSSDConfig will require no modifications.
Patch 0002: Make default config and schema file locations configurable Previously, we were hard-coding the sssd.conf and sssd.api.* locations into the source. With this patch, we will take the default locations from values specified by autoconf.
I'm seeing:
ERROR: files left in build directory after distclean: ./src/config/SSSDConfig/ipachangeconf.py ./src/config/SSSDConfig/sssd_upgrade_config.py
When running make distcheck.
Thanks, I forgot to remove those in the clean-local target.
New patches attached.
On Mon, May 21, 2012 at 02:01:25PM -0400, Stephen Gallagher wrote:
On Mon, 2012-05-21 at 11:36 +0200, Jakub Hrozek wrote:
On Fri, May 18, 2012 at 09:28:20AM -0400, Stephen Gallagher wrote:
Patch 0001: Make SSSDConfig a package We were polluting the primary Python space with several dependencies. We will now install them their own directory/module. This has been done in such a way that existing scripts that import SSSDConfig will require no modifications.
Patch 0002: Make default config and schema file locations configurable Previously, we were hard-coding the sssd.conf and sssd.api.* locations into the source. With this patch, we will take the default locations from values specified by autoconf.
I'm seeing:
ERROR: files left in build directory after distclean: ./src/config/SSSDConfig/ipachangeconf.py ./src/config/SSSDConfig/sssd_upgrade_config.py
When running make distcheck.
Thanks, I forgot to remove those in the clean-local target.
New patches attached.
Ack
On Tue, May 22, 2012 at 11:22:59AM +0200, Jakub Hrozek wrote:
On Mon, May 21, 2012 at 02:01:25PM -0400, Stephen Gallagher wrote:
On Mon, 2012-05-21 at 11:36 +0200, Jakub Hrozek wrote:
On Fri, May 18, 2012 at 09:28:20AM -0400, Stephen Gallagher wrote:
Patch 0001: Make SSSDConfig a package We were polluting the primary Python space with several dependencies. We will now install them their own directory/module. This has been done in such a way that existing scripts that import SSSDConfig will require no modifications.
Patch 0002: Make default config and schema file locations configurable Previously, we were hard-coding the sssd.conf and sssd.api.* locations into the source. With this patch, we will take the default locations from values specified by autoconf.
I'm seeing:
ERROR: files left in build directory after distclean: ./src/config/SSSDConfig/ipachangeconf.py ./src/config/SSSDConfig/sssd_upgrade_config.py
When running make distcheck.
Thanks, I forgot to remove those in the clean-local target.
New patches attached.
Ack
Actually, sorry, but while make distcheck and make rpms work fine, plain "make" is failing for me even after distclean:
CC src/providers/proxy/proxy_child-proxy_child.o make[2]: *** No rule to make target `src/config/SSSDConfig/ipachangeconf.py', needed by `all-am'. Stop. make[2]: *** Waiting for unfinished jobs....
On Tue, 2012-05-22 at 12:59 +0200, Jakub Hrozek wrote:
Actually, sorry, but while make distcheck and make rpms work fine, plain "make" is failing for me even after distclean:
CC src/providers/proxy/proxy_child-proxy_child.o make[2]: *** No rule to make target `src/config/SSSDConfig/ipachangeconf.py', needed by `all-am'. Stop. make[2]: *** Waiting for unfinished jobs....
Turns out I was deleting the file in the 'clean' target without checking whether it was a copy or the original. I fixed this and also tweaked the code to perform the copy so that it is done as its own rule (and thus won't be repeated on subsequent calls to 'make all').
New patches attached. Thanks for catching this. I always do my builds in a parallel build directory, so this was easy for me to miss.
On Wed, May 30, 2012 at 10:09:29PM -0400, Stephen Gallagher wrote:
On Tue, 2012-05-22 at 12:59 +0200, Jakub Hrozek wrote:
Actually, sorry, but while make distcheck and make rpms work fine, plain "make" is failing for me even after distclean:
CC src/providers/proxy/proxy_child-proxy_child.o make[2]: *** No rule to make target `src/config/SSSDConfig/ipachangeconf.py', needed by `all-am'. Stop. make[2]: *** Waiting for unfinished jobs....
Turns out I was deleting the file in the 'clean' target without checking whether it was a copy or the original. I fixed this and also tweaked the code to perform the copy so that it is done as its own rule (and thus won't be repeated on subsequent calls to 'make all').
New patches attached. Thanks for catching this. I always do my builds in a parallel build directory, so this was easy for me to miss.
make, make check and make distcheck all pass now
Ack
On Thu, 2012-05-31 at 10:13 +0200, Jakub Hrozek wrote:
On Wed, May 30, 2012 at 10:09:29PM -0400, Stephen Gallagher wrote:
On Tue, 2012-05-22 at 12:59 +0200, Jakub Hrozek wrote:
Actually, sorry, but while make distcheck and make rpms work fine, plain "make" is failing for me even after distclean:
CC src/providers/proxy/proxy_child-proxy_child.o make[2]: *** No rule to make target `src/config/SSSDConfig/ipachangeconf.py', needed by `all-am'. Stop. make[2]: *** Waiting for unfinished jobs....
Turns out I was deleting the file in the 'clean' target without checking whether it was a copy or the original. I fixed this and also tweaked the code to perform the copy so that it is done as its own rule (and thus won't be repeated on subsequent calls to 'make all').
New patches attached. Thanks for catching this. I always do my builds in a parallel build directory, so this was easy for me to miss.
make, make check and make distcheck all pass now
Ack
Pushed to master.
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Stephen Gallagher