[sssd PR#180][opened] SECRETS: Shutdown the responder in case it becomes idle

[fidencio]

URL: https://github.com/SSSD/sssd/pull/180
Author: fidencio
 Title: #180: SECRETS: Shutdown the responder in case it becomes idle
Action: opened

PR body:
"""
Similarly to what has been done for the other responders, let's shutdown the secrets responder in case it becomes idle.

Resolves:
https://pagure.io/SSSD/sssd/issue/3316

"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/180/head:pr180
git checkout pr180

[sssd PR#180][synchronized] SECRETS: Shutdown the responder in case it becomes idle

[fidencio]

URL: https://github.com/SSSD/sssd/pull/180
Author: fidencio
 Title: #180: SECRETS: Shutdown the responder in case it becomes idle
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/180/head:pr180
git checkout pr180

[sssd PR#180][comment] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

jhrozek commented:
"""
The code looks good and both the PAM responder and the secrets responder now exit on idle. ACK, I will push once CI and Coverity finish.
"""

See the full comment at https://github.com/SSSD/sssd/pull/180#issuecomment-284670587

[sssd PR#180][+Accepted] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

Label: +Accepted

[sssd PR#180][comment] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

jhrozek commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/64/00/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/180#issuecomment-284698438

[sssd PR#180][comment] SECRETS: Shutdown the responder in case it becomes idle

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

lslebodn commented:
"""
Just a little nitpick.

The name of function `responder_get_idle_timer_config_option`
is a little bit confusing. I woudl expect that it will return value
of `idle_timer_config_option`. But it alse setup a timer (
`setup_responder_idle_timer`)

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/180#issuecomment-284700416

[sssd PR#180][+Changes requested] SECRETS: Shutdown the responder in case it becomes idle

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

Label: +Changes requested

[sssd PR#180][-Accepted] SECRETS: Shutdown the responder in case it becomes idle

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

Label: -Accepted

[sssd PR#180][comment] SECRETS: Shutdown the responder in case it becomes idle

[fidencio]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

fidencio commented:
"""
@lslebodn: responder_setup_idle_timer_config() sounds better to you?
"""

See the full comment at https://github.com/SSSD/sssd/pull/180#issuecomment-284701527

[sssd PR#180][comment] SECRETS: Shutdown the responder in case it becomes idle

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

lslebodn commented:
"""
On (07/03/17 03:55), fidencio wrote:
> @lslebodn: responder_setup_idle_timer_config() sounds better to you?

absolutely

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/180#issuecomment-284701963

[sssd PR#180][synchronized] SECRETS: Shutdown the responder in case it becomes idle

[fidencio]

URL: https://github.com/SSSD/sssd/pull/180
Author: fidencio
 Title: #180: SECRETS: Shutdown the responder in case it becomes idle
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/180/head:pr180
git checkout pr180

[sssd PR#180][comment] SECRETS: Shutdown the responder in case it becomes idle

[fidencio]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

fidencio commented:
"""
@lslebodn: changed to responder_setup_idle_timeout_config()

Removing the "Changes Requested" label as @lslebodn comment has been addressed.
"""

See the full comment at https://github.com/SSSD/sssd/pull/180#issuecomment-284704212

[sssd PR#180][-Changes requested] SECRETS: Shutdown the responder in case it becomes idle

[fidencio]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

Label: -Changes requested

[sssd PR#180][comment] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

jhrozek commented:
"""
CI with the new patch: http://sssd-ci.idm.lab.eng.brq.redhat.com:8080/job/ci/6416/
"""

See the full comment at https://github.com/SSSD/sssd/pull/180#issuecomment-285007748

[sssd PR#180][+Accepted] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

Label: +Accepted

[sssd PR#180][closed] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Author: fidencio
 Title: #180: SECRETS: Shutdown the responder in case it becomes idle
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/180/head:pr180
git checkout pr180

[sssd PR#180][comment] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

jhrozek commented:
"""
* master:
 * 4358d76475f0292461a2a479d2149472db103c1d
 * ef268f9e691b0953763fad7e66f0724bed9b3419
"""

See the full comment at https://github.com/SSSD/sssd/pull/180#issuecomment-285018612

[sssd PR#180][+Pushed] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

Label: +Pushed

[sssd PR#180][-Accepted] SECRETS: Shutdown the responder in case it becomes idle

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/180
Title: #180: SECRETS: Shutdown the responder in case it becomes idle

Label: -Accepted