sssd [PATCH] Make socket paths a compile-time option

[Stephen Gallagher]

Previously, we had hardcoded the paths for the NSS, PAM and
private PAM sockets to /var/lib/sss/pipes. With this patch, we
will specify the sockets as $(localstatedir)/lib/sss/pipes.

This fixes a problem builing RPMs on Red Hat Enterprise Linux.
-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

[Simo Sorce]

On Wed, 2009-08-05 at 14:55 -0400, Stephen Gallagher wrote:
>  Previously, we had hardcoded the paths for the NSS, PAM and
>  private PAM sockets to /var/lib/sss/pipes. With this patch, we
>  will specify the sockets as $(localstatedir)/lib/sss/pipes.
>  
>  This fixes a problem builing RPMs on Red Hat Enterprise Linux. 
ack,
Simo.

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/06/2009 04:18 AM, Simo Sorce wrote:
>  On Wed, 2009-08-05 at 14:55 -0400, Stephen Gallagher wrote:
> > Previously, we had hardcoded the paths for the NSS, PAM and
> > private PAM sockets to /var/lib/sss/pipes. With this patch, we
> > will specify the sockets as $(localstatedir)/lib/sss/pipes.
> >
> > This fixes a problem builing RPMs on Red Hat Enterprise Linux.
>  
>  ack,
>  Simo.
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Self-nack. I realized this fix
is incomplete.

I will send a new patch later today.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkp65SIACgkQeiVVYja6o6NAcQCffyZnD3qtMyFltHbO3GK2kSyb
> QDUAnRtsmKTFdeUiqmlavEJ+L6ZG061N
> =q/fJ
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

On 08/06/2009 10:14 AM, Stephen Gallagher wrote:
>  On 08/06/2009 04:18 AM, Simo Sorce wrote:
> > On Wed, 2009-08-05 at 14:55 -0400, Stephen Gallagher wrote:
> >> Previously, we had hardcoded the paths for the NSS, PAM and
> >> private PAM sockets to /var/lib/sss/pipes. With this patch, we
> >> will specify the sockets as $(localstatedir)/lib/sss/pipes.
> >>
> >> This fixes a problem builing RPMs on Red Hat Enterprise Linux.
> > ack,
> > Simo.
>  
> > _______________________________________________
> > sssd-devel mailing list
> > sssd-devel(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
>  Self-nack. I realized this fix is incomplete.
>  
>  I will send a new patch later today.
>   
The correct way to fix this was to rely on the --with-pipe-path
configure option, since we were already doing so for the SBUS sockets.
This patch updates the code so we are relying on the --with-pipe-path
value everywhere.
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

[Simo Sorce]

On Thu, 2009-08-06 at 14:16 -0400, Stephen Gallagher wrote:
>   
>   %define servicename sssd
>  +%define sssdstatedir %{_localstatedir}/lib/sss
>  +%define dbpath %{sssdstatedir}/db
>  +%define pipepath %{sssdstatedir}/lib/sss/pipes 
nack

pipepath is wrong: as is resolves to /var/lib/sss/lib/sss/pipes

Simo.

[Stephen Gallagher]

On 08/10/2009 09:56 AM, Simo Sorce wrote:
>  On Thu, 2009-08-06 at 14:16 -0400, Stephen Gallagher wrote:
> >  
> >  %define servicename sssd
> > +%define sssdstatedir %{_localstatedir}/lib/sss
> > +%define dbpath %{sssdstatedir}/db
> > +%define pipepath %{sssdstatedir}/lib/sss/pipes
>  
>  nack
>  
>  pipepath is wrong: as is resolves to /var/lib/sss/lib/sss/pipes
>  
>  Simo.
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Good catch. Corrected patch attached.



-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

[Stephen Gallagher]

On 08/10/2009 09:58 AM, Stephen Gallagher wrote:
>  On 08/10/2009 09:56 AM, Simo Sorce wrote:
> > On Thu, 2009-08-06 at 14:16 -0400, Stephen Gallagher wrote:
> >>  
> >>  %define servicename sssd
> >> +%define sssdstatedir %{_localstatedir}/lib/sss
> >> +%define dbpath %{sssdstatedir}/db
> >> +%define pipepath %{sssdstatedir}/lib/sss/pipes
> > nack
> >
> > pipepath is wrong: as is resolves to /var/lib/sss/lib/sss/pipes
> >
> > Simo.
> >
> > _______________________________________________
> > sssd-devel mailing list
> > sssd-devel(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
>  
>  Good catch. Corrected patch attached.
>  
>  
>  
>  
>  
>  ------------------------------------------------------------------------
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
One more issue identified during review. The pipe path will be
explicitly set to 0755 permissions.

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

[Stephen Gallagher]

On 08/10/2009 10:57 AM, Stephen Gallagher wrote:
>  On 08/10/2009 09:58 AM, Stephen Gallagher wrote:
> > On 08/10/2009 09:56 AM, Simo Sorce wrote:
> >> On Thu, 2009-08-06 at 14:16 -0400, Stephen Gallagher wrote:
> >>>  
> >>>  %define servicename sssd
> >>> +%define sssdstatedir %{_localstatedir}/lib/sss
> >>> +%define dbpath %{sssdstatedir}/db
> >>> +%define pipepath %{sssdstatedir}/lib/sss/pipes
> >> nack
> >>
> >> pipepath is wrong: as is resolves to /var/lib/sss/lib/sss/pipes
> >>
> >> Simo.
> >>
> >> _______________________________________________
> >> sssd-devel mailing list
> >> sssd-devel(a)lists.fedorahosted.org
> >> https://fedorahosted.org/mailman/listinfo/sssd-devel
> > Good catch. Corrected patch attached.
> >
> >
> >
> >
> >
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > sssd-devel mailing list
> > sssd-devel(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
>  
>  One more issue identified during review. The pipe path will be
>  explicitly set to 0755 permissions.
>  
>  
>  
>  ------------------------------------------------------------------------
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
I realized I mistakenly attached the wrong patch to the previous email.
The correct patch is attached.

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

[Simo Sorce]

On Mon, 2009-08-10 at 12:32 -0400, Stephen Gallagher wrote:
>  
>  I realized I mistakenly attached the wrong patch to the previous
>  email.
>  The correct patch is attached. 
ack.

Simo.

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/11/2009 06:10 AM, Simo Sorce wrote:
>  On Mon, 2009-08-10 at 12:32 -0400, Stephen Gallagher wrote:
> > I realized I mistakenly attached the wrong patch to the previous
> > email.
> > The correct patch is attached.
>  
>  ack.
>  
>  Simo.
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkqBnQoACgkQeiVVYja6o6Nb9gCcCcgkuMrqdwVt4E0YhFhGmd+X
> RGEAn0/FVjSYlHxQlYo1RyERAmlGYf0/
> =MyBk
> -----END PGP SIGNATURE-----