[PATCH] accept_fd_handler: add missing return

[Sumit Bose]

Hi,

I just found this missing return while looking for a different issue.

I wonder why Coverity and friends didn't found it. Is there a way to
tell Coverity to handle talloc_free() similar for free()?

bye,
Sumit

[Jakub Hrozek]

On Mon, Aug 20, 2012 at 11:30:03AM +0200, Sumit Bose wrote:
> Hi,
>
> I just found this missing return while looking for a different issue.

ACK
> I wonder why Coverity and friends didn't found it.

I suspect because the variable is used in a different function that it
is assigned to and that different function is only set as a tevent callback..
> Is there a way to
> tell Coverity to handle talloc_free() similar for free()?

I'm not sure, but I think it would be tricky because of the hierarchical
nature of talloc and the possible use of destructors..
> bye,
> Sumit

[Stephen Gallagher]

On Mon, 2012-08-20 at 12:08 +0200, Jakub Hrozek wrote:
> On Mon, Aug 20, 2012 at 11:30:03AM +0200, Sumit Bose wrote:
> > Hi,
> >
> > I just found this missing return while looking for a different issue.
>
> ACK
> > I wonder why Coverity and friends didn't found it.
>
> I suspect because the variable is used in a different function that it
> is assigned to and that different function is only set as a tevent callback..
> > Is there a way to
> > tell Coverity to handle talloc_free() similar for free()?
>
> I'm not sure, but I think it would be tricky because of the hierarchical
> nature of talloc and the possible use of destructors..

Actually, Coverity is aware of talloc_free() as an alternative for
free(). It has discovered many such memory leaks in the past. I'm not
sure why it missed this one, but it may be as Jakub said.

[Jakub Hrozek]

On Mon, Aug 20, 2012 at 12:08:49PM +0200, Jakub Hrozek wrote:
> On Mon, Aug 20, 2012 at 11:30:03AM +0200, Sumit Bose wrote:
> > Hi,
> >
> > I just found this missing return while looking for a different issue.
>
> ACK

Pushed to master.