8:12 p.m.
This patch addresses https://fedorahosted.org/sssd/ticket/207
See comment to the ticket and in the patch
--
Thank you,
Dmitri Pal
Engineering Manager IPA project,
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
8:54 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/03/2009 03:12 AM, Dmitri Pal wrote:
This patch addresses https://fedorahosted.org/sssd/ticket/207
See comment to the ticket and in the patch
The code that touches elapi_event.c looks OK to me, but the part that
adds a test to elapi_test/elapi_ut.c looks like it belongs to the
previous patch ("ELAPI Rename variables and functions not to use word
template") as it adds a template unit tests.
Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkrJ+rMACgkQHsardTLnvCWVvwCeNGzUfgKOMrFhIeI/83Uknuf3
BbMAmgIUhv1TzpStEkSHPcxBbz2zjFjk
=qiSj
-----END PGP SIGNATURE-----
12:11 p.m.
Jakub Hrozek wrote:
On 10/03/2009 03:12 AM, Dmitri Pal wrote:
> This patch addresses https://fedorahosted.org/sssd/ticket/207
> See comment to the ticket and in the patch
The code that touches elapi_event.c looks OK to me, but the part that
adds a test to elapi_test/elapi_ut.c looks like it belongs to the
previous patch ("ELAPI Rename variables and functions not to use word
template") as it adds a template unit tests.
Jakub
The changes are related to THIS patch.
They test the contents of the template depending upon which host name
resolution flag is passed to template.
The unit test creates templates with just host, host names, ip or IP list.
It is directly related to the host name resolution functionality and
drives its execution in multiple modes.
--
Thank you,
Dmitri Pal
Engineering Manager IPA project,
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
12:58 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/05/2009 01:11 PM, Dmitri Pal wrote:
Jakub Hrozek wrote:
> On 10/03/2009 03:12 AM, Dmitri Pal wrote:
>> This patch addresses https://fedorahosted.org/sssd/ticket/207
>> See comment to the ticket and in the patch
>
>
> The code that touches elapi_event.c looks OK to me, but the part that
> adds a test to elapi_test/elapi_ut.c looks like it belongs to the
> previous patch ("ELAPI Rename variables and functions not to use word
> template") as it adds a template unit tests.
>
> Jakub
The changes are related to THIS patch.
They test the contents of the template depending upon which host name
resolution flag is passed to template.
The unit test creates templates with just host, host names, ip or IP list.
It is directly related to the host name resolution functionality and
drives its execution in multiple modes.
The confusion was sorted out during an IRC conversation. This patch
requires the template patch to work. The templates are needed to
exercise the hostname resolution code.
Ack.
- --
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkrKM6wACgkQeiVVYja6o6PW1gCePk94dJLqaXhMjrXtjRbiUgvr
DOcAnR1IO6VoH3QmvqTCjj5VSAqMANE3
=UN5o
-----END PGP SIGNATURE-----
4:16 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/05/2009 01:58 PM, Stephen Gallagher wrote:
On 10/05/2009 01:11 PM, Dmitri Pal wrote:
> Jakub Hrozek wrote:
>> On 10/03/2009 03:12 AM, Dmitri Pal wrote:
>>> This patch addresses https://fedorahosted.org/sssd/ticket/207
>>> See comment to the ticket and in the patch
>>
>>
>> The code that touches elapi_event.c looks OK to me, but the part that
>> adds a test to elapi_test/elapi_ut.c looks like it belongs to the
>> previous patch ("ELAPI Rename variables and functions not to use word
>> template") as it adds a template unit tests.
>>
>> Jakub
> The changes are related to THIS patch.
> They test the contents of the template depending upon which host name
> resolution flag is passed to template.
> The unit test creates templates with just host, host names, ip or IP list.
> It is directly related to the host name resolution functionality and
> drives its execution in multiple modes.
The confusion was sorted out during an IRC conversation. This patch
requires the template patch to work. The templates are needed to
exercise the hostname resolution code.
Ack.
Pushed to master.
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
- --
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkrKYi8ACgkQeiVVYja6o6Pa/gCeKfbKg/HR5EvWdBoo7JB3XpSb
tOoAoIE4czhHzLzT1QHgv2lHdiSpYfBy
=HnpC
-----END PGP SIGNATURE-----
8:59 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/02/2009 09:12 PM, Dmitri Pal wrote:
This patch addresses https://fedorahosted.org/sssd/ticket/207
See comment to the ticket and in the patch
------------------------------------------------------------------------
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
Nack.
The fix looks correct, but the unit test changes look like they're for a
different patch. Please separate these out.
- --
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkrJ+6QACgkQeiVVYja6o6O+ggCeOraO8nTLAPfyRPT1IZ0hGsI5
a2oAoLId2b3CzdY/3hMIjK/VR21zug0P
=EJHw
-----END PGP SIGNATURE-----
5310
days inactive
5312
days old
sssd-devel@lists.fedorahosted.org
5 comments
3 participants
participants (3)
-
Dmitri Pal -
Jakub Hrozek -
Stephen Gallagher