URL: https://github.com/SSSD/sssd/pull/657 Author: pbrezina Title: #657: be: use be_is_offline for the main domain when asking for domain status Action: opened
PR body: """ The DOM_ACTIVE/INACTIVE flag is not used with the main domain as it is used only for subdomains.
Resolves: https://pagure.io/SSSD/sssd/issue/3830
This is a regression in sbus2 patches. I filed a ticket [1] to make the usage of this flag consistent for all domains. I did not implement it as part of this patch because I expect some caveats there so I kept this patch simple.
[1] https://pagure.io/SSSD/sssd/issue/3831 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/657/head:pr657 git checkout pr657
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status
mzidek-rh commented: """ Can you please add a FIXME comment to the code with short explanation and link to the https://pagure.io/SSSD/sssd/issue/3831 ? The if-else statements look a bit confusing as they are now. """
See the full comment at https://github.com/SSSD/sssd/pull/657#issuecomment-421320079
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status
pbrezina commented: """ I updated the patch. """
See the full comment at https://github.com/SSSD/sssd/pull/657#issuecomment-424683146
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/657 Author: pbrezina Title: #657: be: use be_is_offline for the main domain when asking for domain status Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/657/head:pr657 git checkout pr657
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status
mzidek-rh commented: """ ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/657#issuecomment-426210809
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status
jhrozek commented: """ * master: dfa7bf1133f002a9fbbd3495a70909913db25b16 """
See the full comment at https://github.com/SSSD/sssd/pull/657#issuecomment-426572354
URL: https://github.com/SSSD/sssd/pull/657 Author: pbrezina Title: #657: be: use be_is_offline for the main domain when asking for domain status Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/657/head:pr657 git checkout pr657
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status
Label: +Pushed
sssd-devel@lists.fedorahosted.org