[PATCH] NSS: Don't ignore backslash in usernames with ldap provider

[Lukas Slebodnik]

ehlo,

please review attached patch for regression #2772

LS

[Sumit Bose]

On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote:
> ehlo,
>
> please review attached patch for regression #2772
>
> LS

Hi Lukas,

thank you for taking care of the issue.

The patch is working as expected without breaking the SID lookups and
passes the CI http://sssd-ci.duckdns.org/logs/job/23/92/summary.html so
ACK.

I just want to mention that in the old version it was possible to change
global_names pattern by setting re_expression in the [sssd] section of
sssd.conf. But given the current usage for global_names I can hardly
imagine any reason why the pattern should be changed.

bye,
Sumit

[Jakub Hrozek]

On Mon, Aug 31, 2015 at 09:01:48PM +0200, Sumit Bose wrote:
> On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > please review attached patch for regression #2772
> >
> > LS
>
> Hi Lukas,
>
> thank you for taking care of the issue.
>
> The patch is working as expected without breaking the SID lookups and
> passes the CI http://sssd-ci.duckdns.org/logs/job/23/92/summary.html so
> ACK.
>
> I just want to mention that in the old version it was possible to change
> global_names pattern by setting re_expression in the [sssd] section of
> sssd.conf. But given the current usage for global_names I can hardly
> imagine any reason why the pattern should be changed.
>
> bye,
> Sumit

* master: 90b8e2e47ecc0dd555cae401a0c9b082d12ab989

[Lukas Slebodnik]

On (31/08/15 21:01), Sumit Bose wrote:
> On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > please review attached patch for regression #2772
> >
> > LS
>
> Hi Lukas,
>
> thank you for taking care of the issue.
>
> The patch is working as expected without breaking the SID lookups and
> passes the CI http://sssd-ci.duckdns.org/logs/job/23/92/summary.html so
> ACK.
>
> I just want to mention that in the old version it was possible to change
> global_names pattern by setting re_expression in the [sssd] section of
> sssd.conf. But given the current usage for global_names I can hardly
> imagine any reason why the pattern should be changed.

I'm little bit confused.

Should we implement overriding global_names with re_expression
in the [sssd] section? Is there a valid use-case?

OR

Is better that users cannot override it?

I think it's late for downstream but we can file at least upstream ticket.

LS

[Sumit Bose]

On Wed, Sep 02, 2015 at 01:23:11PM +0200, Lukas Slebodnik wrote:
> On (31/08/15 21:01), Sumit Bose wrote:
> > On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > please review attached patch for regression #2772
> > >
> > > LS
> >
> > Hi Lukas,
> >
> > thank you for taking care of the issue.
> >
> > The patch is working as expected without breaking the SID lookups and
> > passes the CI http://sssd-ci.duckdns.org/logs/job/23/92/summary.html so
> > ACK.
> >
> > I just want to mention that in the old version it was possible to change
> > global_names pattern by setting re_expression in the [sssd] section of
> > sssd.conf. But given the current usage for global_names I can hardly
> > imagine any reason why the pattern should be changed.
>
> I'm little bit confused.
>
> Should we implement overriding global_names with re_expression
> in the [sssd] section? Is there a valid use-case?
>
> OR
>
> Is better that users cannot override it?
>
> I think it's late for downstream but we can file at least upstream ticket.

no, the current state is fine. As said I cannot think of a use-case, if
there is one coming up later we can add an option to change global_names
then.

bye,
Sumit
> LS
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Lukas Slebodnik]

On (02/09/15 14:10), Sumit Bose wrote:
> On Wed, Sep 02, 2015 at 01:23:11PM +0200, Lukas Slebodnik wrote:
> > On (31/08/15 21:01), Sumit Bose wrote:
> > > On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote:
> > > > ehlo,
> > > >
> > > > please review attached patch for regression #2772
> > > >
> > > > LS
> > >
> > > Hi Lukas,
> > >
> > > thank you for taking care of the issue.
> > >
> > > The patch is working as expected without breaking the SID lookups and
> > > passes the CI http://sssd-ci.duckdns.org/logs/job/23/92/summary.html so
> > > ACK.
> > >
> > > I just want to mention that in the old version it was possible to change
> > > global_names pattern by setting re_expression in the [sssd] section of
> > > sssd.conf. But given the current usage for global_names I can hardly
> > > imagine any reason why the pattern should be changed.
> >
> > I'm little bit confused.
> >
> > Should we implement overriding global_names with re_expression
> > in the [sssd] section? Is there a valid use-case?
> >
> > OR
> >
> > Is better that users cannot override it?
> >
> > I think it's late for downstream but we can file at least upstream ticket.
>
> no, the current state is fine. As said I cannot think of a use-case, if
> there is one coming up later we can add an option to change global_names
> then.

Thank you very much for clarification.

LS