[PATCH] RPM: BuildRequire selinux-policy-targeted

[Jakub Hrozek]

We check the presence of the directory /etc/selinux/targeted/logins to
determine if the platform supports per-user SELinux logins.

However, I forgot to BuildRequire that directory, so RPMs built in mock
failed to detect it completely unlike my test RPMs built locally.

The other alternative I was considering was a simple switch that would
be disabled on old platforms and enabled on new platforms but a) I don't
lke the idea of yet another switch and b) I'd like the feature to work
correctly on all platforms automatically, even on other distributions.

[Ondrej Kos]

On 09/07/2012 06:29 PM, Jakub Hrozek wrote:
> We check the presence of the directory /etc/selinux/targeted/logins to
> determine if the platform supports per-user SELinux logins.
>
> However, I forgot to BuildRequire that directory, so RPMs built in mock
> failed to detect it completely unlike my test RPMs built locally.
>
> The other alternative I was considering was a simple switch that would
> be disabled on old platforms and enabled on new platforms but a) I don't
> lke the idea of yet another switch and b) I'd like the feature to work
> correctly on all platforms automatically, even on other distributions.
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Ack

[Jakub Hrozek]

On Mon, Sep 10, 2012 at 09:39:30AM +0200, Ondrej Kos wrote:
> On 09/07/2012 06:29 PM, Jakub Hrozek wrote:
> > We check the presence of the directory /etc/selinux/targeted/logins to
> > determine if the platform supports per-user SELinux logins.
> >
> > However, I forgot to BuildRequire that directory, so RPMs built in mock
> > failed to detect it completely unlike my test RPMs built locally.
> >
> > The other alternative I was considering was a simple switch that would
> > be disabled on old platforms and enabled on new platforms but a) I don't
> > lke the idea of yet another switch and b) I'd like the feature to work
> > correctly on all platforms automatically, even on other distributions.
> >
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
> Ack

Pushed to master.

[Jakub Hrozek]

On Mon, Sep 10, 2012 at 10:31:44AM +0200, Jakub Hrozek wrote:
> On Mon, Sep 10, 2012 at 09:39:30AM +0200, Ondrej Kos wrote:
> > On 09/07/2012 06:29 PM, Jakub Hrozek wrote:
> > > We check the presence of the directory /etc/selinux/targeted/logins to
> > > determine if the platform supports per-user SELinux logins.
> > >
> > > However, I forgot to BuildRequire that directory, so RPMs built in mock
> > > failed to detect it completely unlike my test RPMs built locally.
> > >
> > > The other alternative I was considering was a simple switch that would
> > > be disabled on old platforms and enabled on new platforms but a) I don't
> > > lke the idea of yet another switch and b) I'd like the feature to work
> > > correctly on all platforms automatically, even on other distributions.
> > >
> > > sssd-devel mailing list
> > > [e-mail]
> > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >
> > Ack
>
> Pushed to master.

For the record, I also asked Dan Walsh in an e-mail if there was any
better way to detect whether the correct selinux-policy version is
present. But I need a fix fast to unblock testing, so I just went ahead
and pushed this patch.