[sssd PR#5535][opened] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Author: alexey-tikhonov
 Title: #5535: A set of patches to sanitize logger code a little bit.
Action: opened

PR body:
"""

"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5535/head:pr5535
git checkout pr5535

[sssd PR#5535][edited] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Author: alexey-tikhonov
 Title: #5535: A set of patches to sanitize logger code a little bit.
Action: edited

Changed field: body
Original value:
"""

"""

[sssd PR#5535][+Waiting for review] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

Label: +Waiting for review

[sssd PR#5535][synchronized] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Author: alexey-tikhonov
 Title: #5535: A set of patches to sanitize logger code a little bit.
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5535/head:pr5535
git checkout pr5535

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[thalman]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

thalman commented:
"""
I went trough the patches, looks good to me. I will run few tests before acking.

Thanks
Tom
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-805980947

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[thalman]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

thalman commented:
"""
Just for the record: Testing on my fedora shows that the patch as is prevents sssd to log into files in our current setup.
We discussed it on IRC and @alexey-tikhonov will send an update later.

Thanks
Tom
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-810993255

[sssd PR#5535][synchronized] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Author: alexey-tikhonov
 Title: #5535: A set of patches to sanitize logger code a little bit.
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5535/head:pr5535
git checkout pr5535

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

alexey-tikhonov commented:
"""
Thanks. Updated.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-811050236

[sssd PR#5535][+Accepted] A set of patches to sanitize logger code a little bit.

[thalman]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

Label: +Accepted

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[thalman]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

thalman commented:
"""
Thanks for the patch
ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-811142086

[sssd PR#5535][-Waiting for review] A set of patches to sanitize logger code a little bit.

[thalman]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

Label: -Waiting for review

[sssd PR#5535][+Ready to push] A set of patches to sanitize logger code a little bit.

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

Label: +Ready to push

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5535

* `master`
    * 66960c76952baf6b636d4f1949822710a3dc7da8 - MONITOR: in case '-i' is given don't force logger to 'stderr' if its value specified explictly
    * 0cddb67128edc86be4163489e29eaa3c4e123b7b - DEBUG: introduce SSSDBG_TOOLS_DEFAULT
    * 21334de236390e0e946d6a4fcde306f41a932214 - MONITOR: added logging of cmd used to start services
    * dde57f76854d40a01f53655e633c17c5aea187a4 - DEBUG: incorporate open_debug_file() into DEBUG_INIT
    * 374d644f00a16c49deaba520cb05ba08ed5a34cb - Moved SSSDBG_MASK_ALL out of debug.h since is it is only used in tests.
    * cf699170443387955df32cb1ea5e20e477abc2ff - DEBUG: added several comments to debug.h API and moved rarely used / "private" functions to the bottom.
    * 4d133e154845f225a8459636e06b18c0dfbb286f - DEBUG: remove sss_set_logger() from public API
    * c14e439cf300db3f6a78bb97d7622550e1d61676 - DEBUG: incorporate sss_set_logger() into DEBUG_INIT
    * fc5b64e8bfa9ce58bdb0adc68592954a3865e00e - DEBUG: make use of existing SSSD_DEBUG_OPTS macro
    * fee3883bb4cbf0a6e296de3bbf6ecf753932a48b - DEBUG: use '--logger' as the only option to configure logger type.
    * 0dfb188ee2ae718d024ca939c816a8dec9527444 - Moved declaration of debug related helpers defined in debug.c from util.h to debug.h
    * 0fd0681d3a1476676064e752733b01f33d815659 - Moved ldb_debug_messages() out of UTILS to SYSDB

"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-811786128

[sssd PR#5535][+Pushed] A set of patches to sanitize logger code a little bit.

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

Label: +Pushed

[sssd PR#5535][-Accepted] A set of patches to sanitize logger code a little bit.

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

Label: -Accepted

[sssd PR#5535][-Ready to push] A set of patches to sanitize logger code a little bit.

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

Label: -Ready to push

[sssd PR#5535][closed] A set of patches to sanitize logger code a little bit.

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5535
Author: alexey-tikhonov
 Title: #5535: A set of patches to sanitize logger code a little bit.
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5535/head:pr5535
git checkout pr5535

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[joakim-tjernlund]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

joakim-tjernlund commented:
"""
This PR forgot to change -f in src/sysv/gentoo/sssd.in so sssd now fails to start as -f option is not recognized.
Please replace -f with --logger=files
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-812456635

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

alexey-tikhonov commented:
"""
> This PR forgot to change -f in src/sysv/gentoo/sssd.in so sssd now fails to start as -f option is not recognized.
> Please replace -f with --logger=files

@joakim-tjernlund , do we really need distribution-specific config in upstream repo?

@scabrero , do you use https://github.com/SSSD/sssd/blob/master/src/sysv/SUSE/sssd.in somehow?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-813965605

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[joakim-tjernlund]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

joakim-tjernlund commented:
"""
> > This PR forgot to change -f in src/sysv/gentoo/sssd.in so sssd now fails to start as -f option is not recognized.
> > Please replace -f with --logger=files
>
> @joakim-tjernlund , do we really need distribution-specific config in upstream repo?
>
> @scabrero , do you use https://github.com/SSSD/sssd/blob/master/src/sysv/SUSE/sssd.in somehow?

Hi, I don't think we need dist. specific ones but there are variables in there that needs processing.
Also, Gentoo vs. SUSE, the Gentoo one is openrc while SUSE is a plain script so you cannot merge them into one.

"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-813997650

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[joakim-tjernlund]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

joakim-tjernlund commented:
"""
To be clear, you could have a generic openrc script and a generic SYSV shell script
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-814002391

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

alexey-tikhonov commented:
"""
> Hi, I don't think we need dist. specific ones but there are variables in there that needs processing.

Is this file really used in Gentoo?
There are:
https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-auth/sssd/files/sssd.serv...
https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-auth/sssd/files/sssd

But I'm really not familiar with Gentoo packaging thus asking.
> To be clear, you could have a generic openrc script and a generic SYSV shell script

Yes, this makes sense.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-814005633

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[joakim-tjernlund]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

joakim-tjernlund commented:
"""
> > Hi, I don't think we need dist. specific ones but there are variables in there that needs processing.
>
> Is this file really used in Gentoo?
> There are:
> https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-auth/sssd/files/sssd.serv...
> https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-auth/sssd/files/sssd
>
> But I'm really not familiar with Gentoo packaging thus asking.

Yes, you can choose systemd or openrc at build time(Gentoo is a source based dist so every SW pkg are built locally)
The sssd.service is just used in old 2.2.0. Same for sssd file.

"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-814010211

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

alexey-tikhonov commented:
"""
Ok, so probably we could rename `sysv/gentoo/sssd.in` to `sysv/openrc/sssd.in` and get rid of `sysv/SUSE/` (merge to `sysv/sssd.in`)...
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-814015832

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[scabrero]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

scabrero commented:
"""
> @scabrero , do you use https://github.com/SSSD/sssd/blob/master/src/sysv/SUSE/sssd.in somehow?

No we don't use it. We are using src/sysv/systemd/*.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-814135680

[sssd PR#5535][comment] A set of patches to sanitize logger code a little bit.

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5535
Title: #5535: A set of patches to sanitize logger code a little bit.

alexey-tikhonov commented:
"""
https://github.com/SSSD/sssd/pull/5569
"""

See the full comment at https://github.com/SSSD/sssd/pull/5535#issuecomment-814214240