[sssd PR#406][opened] IPA: sanitize name in override search filter

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/406
Author: sumit-bose
 Title: #406: IPA: sanitize name in override search filter
Action: opened

PR body:
"""
Resolves https://pagure.io/SSSD/sssd/issue/3545
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/406/head:pr406
git checkout pr406

[sssd PR#406][comment] IPA: sanitize name in override search filter

[fidencio]

URL: https://github.com/SSSD/sssd/pull/406
Title: #406: IPA: sanitize name in override search filter

fidencio commented:
"""
@sumit-bose, code-wise the patch looks okay and I'll manually test the patch later Today.

One things that worries me a little bit here is that we've been bitten by not sanitized names before a few times. So, I'm wondering here whether the other filter calls have been checked already or we should file a bug for that (as I don't think it should be solved as part of this PR).
"""

See the full comment at https://github.com/SSSD/sssd/pull/406#issuecomment-336841219

[sssd PR#406][comment] IPA: sanitize name in override search filter

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/406
Title: #406: IPA: sanitize name in override search filter

sumit-bose commented:
"""
@fidencio, I think it is a good idea to file a ticket to review the current filters and to think of a way how to handle this more safe in general.
"""

See the full comment at https://github.com/SSSD/sssd/pull/406#issuecomment-336845528

[sssd PR#406][comment] IPA: sanitize name in override search filter

[fidencio]

URL: https://github.com/SSSD/sssd/pull/406
Title: #406: IPA: sanitize name in override search filter

fidencio commented:
"""
@sumit-bose, manual tests just worked fine here.

I've fired an internal CI run and I'll add the "Accepted" label as soon as I get the results.
"""

See the full comment at https://github.com/SSSD/sssd/pull/406#issuecomment-337395651

[sssd PR#406][comment] IPA: sanitize name in override search filter

[fidencio]

URL: https://github.com/SSSD/sssd/pull/406
Title: #406: IPA: sanitize name in override search filter

fidencio commented:
"""
Ci: http://vm-058-233.$%7Babc%7D/logs/job/79/74/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/406#issuecomment-337473295

[sssd PR#406][+Accepted] IPA: sanitize name in override search filter

[fidencio]

URL: https://github.com/SSSD/sssd/pull/406
Title: #406: IPA: sanitize name in override search filter

Label: +Accepted

[sssd PR#406][comment] IPA: sanitize name in override search filter

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/406
Title: #406: IPA: sanitize name in override search filter

lslebodn commented:
"""
master:
* c2dec0dc740ba426f26563563c0aea3a38f3c3c1

sssd-1-14:
* f9f627d4931757682d2febe76c03cb043d05a100
"""

See the full comment at https://github.com/SSSD/sssd/pull/406#issuecomment-337557005

[sssd PR#406][closed] IPA: sanitize name in override search filter

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/406
Author: sumit-bose
 Title: #406: IPA: sanitize name in override search filter
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/406/head:pr406
git checkout pr406

[sssd PR#406][comment] IPA: sanitize name in override search filter

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/406
Title: #406: IPA: sanitize name in override search filter

lslebodn commented:
"""
and version for 1.13 should be here
https://github.com/SSSD/sssd/pull/410
"""

See the full comment at https://github.com/SSSD/sssd/pull/406#issuecomment-337557102

[sssd PR#406][+Pushed] IPA: sanitize name in override search filter

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/406
Title: #406: IPA: sanitize name in override search filter

Label: +Pushed