[PATCH] NSS: Set packet length for initgroups

[Lukas Slebodnik]

ehlo,

attached patch resolves ticket #2138: 
Valgrind sssd "Syscall param socketcall.sendto(msg) points to uninitialised
byte(s)"

LS

[Michal Židek]

On 11/05/2013 06:37 PM, Lukas Slebodnik wrote:
>   ((uint32_t *)body)[1] = 0; /* reserved */
> sss_packet_set_size(packet, (2 + bindex) *  sizeof(uint32_t));

Please, check the return value of sss_packet_set_size.
>   return EOK;
>
> }

Michal

[Lukas Slebodnik]

On (05/11/13 18:49), Michal Židek wrote:
> On 11/05/2013 06:37 PM, Lukas Slebodnik wrote:
> >  ((uint32_t *)body)[1] = 0; /* reserved */
> > sss_packet_set_size(packet, (2 + bindex) *  sizeof(uint32_t));
>
> Please, check the return value of sss_packet_set_size.
> >  return EOK;
> >
> > }

Thank you for review.

Updated patch is attached.

LS

[Jakub Hrozek]

On Tue, Nov 05, 2013 at 07:11:38PM +0100, Lukas Slebodnik wrote:
> On (05/11/13 18:49), Michal Židek wrote:
> > On 11/05/2013 06:37 PM, Lukas Slebodnik wrote:
> > >  ((uint32_t *)body)[1] = 0; /* reserved */
> > > sss_packet_set_size(packet, (2 + bindex) *  sizeof(uint32_t));
> >
> > Please, check the return value of sss_packet_set_size.
> > >  return EOK;
> > >
> > > }
>
> Thank you for review.
>
> Updated patch is attached.
>
> LS

Michal's concern was addressed, code looks good and initgroups works
fine.

ACK

[Jakub Hrozek]

On Thu, Nov 07, 2013 at 11:14:35AM +0100, Jakub Hrozek wrote:
> On Tue, Nov 05, 2013 at 07:11:38PM +0100, Lukas Slebodnik wrote:
> > On (05/11/13 18:49), Michal Židek wrote:
> > > On 11/05/2013 06:37 PM, Lukas Slebodnik wrote:
> > > >  ((uint32_t *)body)[1] = 0; /* reserved */
> > > > sss_packet_set_size(packet, (2 + bindex) *  sizeof(uint32_t));
> > >
> > > Please, check the return value of sss_packet_set_size.
> > > >  return EOK;
> > > >
> > > > }
> >
> > Thank you for review.
> >
> > Updated patch is attached.
> >
> > LS
>
> Michal's concern was addressed, code looks good and initgroups works
> fine.
>
> ACK

Pushed to master and sssd-1-11