URL: https://github.com/SSSD/sssd/pull/640 Author: mrniranjan Title: #640: Python3 changes to multihost tests Action: opened
PR body: """ 1. Python3 related changes 2. converting ldap attributes to use bytes
Signed-off-by: Niranjan M.R mrniranjan@redhat.com """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/640/head:pr640 git checkout pr640
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/640#issuecomment-413660392
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
fidencio commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/640#issuecomment-413663854
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
fidencio commented: """ Patch looks good and I've fired a CI run. I'll Ack as soon as I get the results.
@mrniranjan, do you need/want a review from someone else from your team as well? """
See the full comment at https://github.com/SSSD/sssd/pull/640#issuecomment-413667084
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
madhuriupadhye commented: """ Patch looks good to me. """
See the full comment at https://github.com/SSSD/sssd/pull/640#issuecomment-413771568
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
fidencio commented: """ CI: http://vm-031.$%7Babc%7D/logs/job/91/90/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/640#issuecomment-413776902
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
fidencio commented: """ I'm removing the "Accepted" label as @mrniranjan will send a few more patches in this very same PR. """
See the full comment at https://github.com/SSSD/sssd/pull/640#issuecomment-413820660
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
fidencio commented: """ After a second talk with @mrniranjan, he told me to go ahead and the changes will be submit in a second PR. """
See the full comment at https://github.com/SSSD/sssd/pull/640#issuecomment-413852624
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
fidencio commented: """ master: c0374e1 """
See the full comment at https://github.com/SSSD/sssd/pull/640#issuecomment-413853181
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/640 Title: #640: Python3 changes to multihost tests
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/640 Author: mrniranjan Title: #640: Python3 changes to multihost tests Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/640/head:pr640 git checkout pr640
sssd-devel@lists.fedorahosted.org
-
centos-ci -
fidencio
-
madhuriupadhye
-
mrniranjan