[sssd PR#5788][opened] debug: suppress backtrace if GetAccountDomain() is not supported

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5788
Author: sumit-bose
 Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported
Action: opened

PR body:
"""
The return code ERR_GET_ACCT_DOM_NOT_SUPPORTED is an expected return code
if the backend does not support the GetAccountDomain() request and there is
no need to trigger a backtrace in the logs in this case.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5788/head:pr5788
git checkout pr5788

[sssd PR#5788][synchronized] debug: suppress backtrace if GetAccountDomain() is not supported

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5788
Author: sumit-bose
 Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5788/head:pr5788
git checkout pr5788

[sssd PR#5788][comment] debug: suppress backtrace if GetAccountDomain() is not supported

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

alexey-tikhonov commented:
"""
Patches look good to me.
But strictly speaking commit message of a first patch isn't correct anymore: backtrace is suppressed for all backend errors (not only `ERR_GET_ACCT_DOM_NOT_SUPPORTED`), and debug level for `ERR_GET_ACCT_DOM_NOT_SUPPORTED` is reduced.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5788#issuecomment-926411044

[sssd PR#5788][comment] debug: suppress backtrace if GetAccountDomain() is not supported

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

alexey-tikhonov commented:
"""
Patches look good to me.
But strictly speaking commit message of a first patch isn't correct anymore: backtrace is suppressed for all backend errors (not only `ERR_GET_ACCT_DOM_NOT_SUPPORTED`), and debug level for `ERR_GET_ACCT_DOM_NOT_SUPPORTED` is lowered.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5788#issuecomment-926411044

[sssd PR#5788][synchronized] debug: suppress backtrace if GetAccountDomain() is not supported

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5788
Author: sumit-bose
 Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5788/head:pr5788
git checkout pr5788

[sssd PR#5788][comment] debug: suppress backtrace if GetAccountDomain() is not supported

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

sumit-bose commented:
"""
> Patches look good to me.
> But strictly speaking commit message of a first patch isn't correct anymore: backtrace is suppressed for all backend errors (not only `ERR_GET_ACCT_DOM_NOT_SUPPORTED`), and debug level for `ERR_GET_ACCT_DOM_NOT_SUPPORTED` is lowered.

Hi,

thanks for the hint, I updated the commit message.

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/5788#issuecomment-926501776

[sssd PR#5788][+Accepted] debug: suppress backtrace if GetAccountDomain() is not supported

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

Label: +Accepted

[sssd PR#5788][+Ready to push] debug: suppress backtrace if GetAccountDomain() is not supported

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

Label: +Ready to push

[sssd PR#5788][comment] debug: suppress backtrace if GetAccountDomain() is not supported

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5788

* `master`
    * ca8b655fb676dde48eb72cfa6a520c696ada362c - debug: suppress backtrace for backend errors
    * e92988a627b8be3dd5d4f875861b511fa11586ab - debug: reduce logging of GetAccountDomain() in the frontends

"""

See the full comment at https://github.com/SSSD/sssd/pull/5788#issuecomment-926583675

[sssd PR#5788][+Pushed] debug: suppress backtrace if GetAccountDomain() is not supported

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

Label: +Pushed

[sssd PR#5788][-Accepted] debug: suppress backtrace if GetAccountDomain() is not supported

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

Label: -Accepted

[sssd PR#5788][-Ready to push] debug: suppress backtrace if GetAccountDomain() is not supported

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5788
Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported

Label: -Ready to push

[sssd PR#5788][closed] debug: suppress backtrace if GetAccountDomain() is not supported

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5788
Author: sumit-bose
 Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5788/head:pr5788
git checkout pr5788