[sssd PR#824][opened] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: opened

PR body:
"""
Implicit files domain gets activated when no sssd.conf present
and sssd is started. This does not respect --disable-files-domain
configure option

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1713352
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][synchronized] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

alexey-tikhonov commented:
"""
Patch set looks strange...
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-511336736

[sssd PR#824][synchronized] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][synchronized] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[thalman]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

thalman commented:
"""
>  Patch set looks strange...
>  
Yes, some cherry pick mistake I did. Fixed now.
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-511353741

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[thalman]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

thalman commented:
"""
>  Patch set looks strange...
>  
Yes, some cherry pick mistake I did. Fixed now.
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-511353741

[sssd PR#824][edited] WIP: CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: WIP: CONFDB: Files domain if activated without .conf
Action: edited

 Changed field: title
Original value:
"""
CONFDB: Files domain if activated without .conf
"""

[sssd PR#824][edited] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: edited

 Changed field: title
Original value:
"""
WIP: CONFDB: Files domain if activated without .conf
"""

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[thalman]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

thalman commented:
"""
Test passed on my VM
```[thalman@client sssd]$ ./contrib/ci/run -m
install-deps:           success  00:00:01 ci-install-deps.log
pep8:                   success  00:00:02 ci-pep8.log
autoreconf:             success  00:00:13 ci-autoreconf.log
DEBUG BUILD:                              ci-build-debug
configure:              success  00:00:23 ci-build-debug/ci-configure.log
make-tests:             success  00:20:52 ci-build-debug/ci-make-tests.log
make-intgcheck:         success  00:30:55 ci-build-debug/ci-make-intgcheck.log
```
Can we access the ci-build-debug/ci-make-intgcheck.log from our CI? I can see only console
output.
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-511775792

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

jhrozek commented:
"""
@alexey-tikhonov do you also plan on reviewing this PR?
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-513903655

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

jhrozek commented:
"""
@thalman can you re-push the PR so that the internal CI also gets triggered?
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-513903766

[sssd PR#824][synchronized] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[thalman]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

thalman commented:
"""
@jhrozek re-pushed
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-518590416

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

jhrozek commented:
"""
retest this please
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-519099537

[sssd PR#824][synchronized] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][synchronized] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[thalman]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

thalman commented:
"""
@jhrozek rebased/pushed. Still some CI tests fail. IMO errors are not connected with PR.
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-519394752

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

jhrozek commented:
"""
retest this please
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-521162256

[sssd PR#824][synchronized] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][synchronized] CONFDB: Files domain if activated without .conf

[thalman]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

mzidek-rh commented:
"""
ACK to the patches.
"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-533061642

[sssd PR#824][+Accepted] CONFDB: Files domain if activated without .conf

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

Label: +Accepted

[sssd PR#824][+Ready to push] CONFDB: Files domain if activated without .conf

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

Label: +Ready to push

[sssd PR#824][comment] CONFDB: Files domain if activated without .conf

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

pbrezina commented:
"""
* `sssd-1-16`
  * e48cdfb69b43964d5472bdf011af59343c719a06 - TESTS: adapt tests to enabled default files
domain
  * 5b571efa60f8ce86089772fdd43555174692d0d2 - CONFDB: Files domain if activated without
.conf

"""

See the full comment at https://github.com/SSSD/sssd/pull/824#issuecomment-533463326

[sssd PR#824][closed] CONFDB: Files domain if activated without .conf

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/824
Author: thalman
 Title: #824: CONFDB: Files domain if activated without .conf
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/824/head:pr824
git checkout pr824

[sssd PR#824][-Accepted] CONFDB: Files domain if activated without .conf

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

Label: -Accepted

[sssd PR#824][-Ready to push] CONFDB: Files domain if activated without .conf

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

Label: -Ready to push

[sssd PR#824][+Pushed] CONFDB: Files domain if activated without .conf

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/824
Title: #824: CONFDB: Files domain if activated without .conf

Label: +Pushed