Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
On 12/07/2014 05:32 PM, Dmitri Pal wrote:
Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Cleaned couple things. This is a better set
On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
On 12/07/2014 05:32 PM, Dmitri Pal wrote:
Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Cleaned couple things. This is a better set
Pavel, can you check if the API would allow you to use libini_config instead of augeas?
On 12/08/2014 10:46 AM, Jakub Hrozek wrote:
On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
On 12/07/2014 05:32 PM, Dmitri Pal wrote:
Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Cleaned couple things. This is a better set
Pavel, can you check if the API would allow you to use libini_config instead of augeas?
For some reason the patches are not directly applicable by git. I had to remove the first character '>' from each patch before applying. After that, it cannot be applied to the ding-libs master, it fails with:
error: patch failed: Makefile.am:251 error: Makefile.am: patch does not apply Patch failed at 0009 Build new interface
Are those patches dependent on some other patches?
Anyway, the interface should be good. I guess that the only thing I am missing from augeas functionality is the save function.
On 12/08/2014 01:10 PM, Pavel Březina wrote:
On 12/08/2014 10:46 AM, Jakub Hrozek wrote:
On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
On 12/07/2014 05:32 PM, Dmitri Pal wrote:
Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Cleaned couple things. This is a better set
Pavel, can you check if the API would allow you to use libini_config instead of augeas?
For some reason the patches are not directly applicable by git. I had to remove the first character '>' from each patch before applying. After that, it cannot be applied to the ding-libs master, it fails with:
error: patch failed: Makefile.am:251 error: Makefile.am: patch does not apply Patch failed at 0009 Build new interface
Are those patches dependent on some other patches?
Anyway, the interface should be good. I guess that the only thing I am missing from augeas functionality is the save function. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
I am puzzled how ">" ended up in all the patches. I regenerated a new set and there is no ">" there.
Also you are right. I have a patch that is in my tree since for me autotools do not work with the current Makefile.am. I had to make a one line change but it is close to the place where I did other change so patch 9 might not apply cleanly. To avoid that I moved the lines around and generated a new version of patch 9. I hope it would apply cleanly.
Thanks for checking!
The save part will be done as a part of the fileobj API. It will include functions like: - save backup in the given location - change file ownership/permissions - save file
On (08/12/14 14:19), Dmitri Pal wrote:
On 12/08/2014 01:10 PM, Pavel Březina wrote:
On 12/08/2014 10:46 AM, Jakub Hrozek wrote:
On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
On 12/07/2014 05:32 PM, Dmitri Pal wrote:
Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
Cleaned couple things. This is a better set
Pavel, can you check if the API would allow you to use libini_config instead of augeas?
For some reason the patches are not directly applicable by git. I had to remove the first character '>' from each patch before applying. After that, it cannot be applied to the ding-libs master, it fails with:
error: patch failed: Makefile.am:251 error: Makefile.am: patch does not apply Patch failed at 0009 Build new interface
Are those patches dependent on some other patches?
Anyway, the interface should be good. I guess that the only thing I am missing from augeas functionality is the save function.
I am puzzled how ">" ended up in all the patches. I regenerated a new set and there is no ">" there.
Also you are right. I have a patch that is in my tree since for me autotools do not work with the current Makefile.am. I had to make a one line change but
IIRC we disabled error generated by automake. (there should be just warning) and you should not need any additional patches to build ding-libs on epel6.
LS
On 12/08/2014 08:19 PM, Dmitri Pal wrote:
On 12/08/2014 01:10 PM, Pavel Březina wrote:
On 12/08/2014 10:46 AM, Jakub Hrozek wrote:
On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
On 12/07/2014 05:32 PM, Dmitri Pal wrote:
Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Cleaned couple things. This is a better set
Pavel, can you check if the API would allow you to use libini_config instead of augeas?
For some reason the patches are not directly applicable by git. I had to remove the first character '>' from each patch before applying. After that, it cannot be applied to the ding-libs master, it fails with:
error: patch failed: Makefile.am:251 error: Makefile.am: patch does not apply Patch failed at 0009 Build new interface
Are those patches dependent on some other patches?
Anyway, the interface should be good. I guess that the only thing I am missing from augeas functionality is the save function. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
I am puzzled how ">" ended up in all the patches. I regenerated a new set and there is no ">" there.
I think Thunderbird&mailman integration do this. See a proposed fix on
http://www.freeipa.org/page/Contribute/Patch_Format#Thunderbird_formatting_o...
Also you are right. I have a patch that is in my tree since for me autotools do not work with the current Makefile.am. I had to make a one line change but it is close to the place where I did other change so patch 9 might not apply cleanly. To avoid that I moved the lines around and generated a new version of patch 9. I hope it would apply cleanly.
Thanks for checking!
The save part will be done as a part of the fileobj API. It will include functions like:
- save backup in the given location
- change file ownership/permissions
- save file
I have not checked the code itself, I just noticed that "From" attribute is wrong. It says
From: Dmitri Pal dpal@dpal.csb
while it should rather say
From: Dmitri Pal dpal@redhat.com
to not spoil the git shortlog.
Martin
On Tue, Dec 09, 2014 at 02:24:12PM +0100, Martin Kosek wrote:
I have not checked the code itself, I just noticed that "From" attribute is wrong. It says
From: Dmitri Pal dpal@dpal.csb
while it should rather say
From: Dmitri Pal dpal@redhat.com
to not spoil the git shortlog.
fwiw, I fixed the e-mail (with git commit --amend --author) in the previous ding-libs patchset I pushed so that the mail would be correct.
Dmitri, you can set the e-mail address with: git config --global user.email dpal@redhat.com
On 12/09/2014 08:24 AM, Martin Kosek wrote:
On 12/08/2014 08:19 PM, Dmitri Pal wrote:
On 12/08/2014 01:10 PM, Pavel Březina wrote:
On 12/08/2014 10:46 AM, Jakub Hrozek wrote:
On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
On 12/07/2014 05:32 PM, Dmitri Pal wrote:
Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Cleaned couple things. This is a better set
Pavel, can you check if the API would allow you to use libini_config instead of augeas?
For some reason the patches are not directly applicable by git. I had to remove the first character '>' from each patch before applying. After that, it cannot be applied to the ding-libs master, it fails with:
error: patch failed: Makefile.am:251 error: Makefile.am: patch does not apply Patch failed at 0009 Build new interface
Are those patches dependent on some other patches?
Anyway, the interface should be good. I guess that the only thing I am missing from augeas functionality is the save function. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
I am puzzled how ">" ended up in all the patches. I regenerated a new set and there is no ">" there.
I think Thunderbird&mailman integration do this. See a proposed fix on
http://www.freeipa.org/page/Contribute/Patch_Format#Thunderbird_formatting_o...
Changed.
Also you are right. I have a patch that is in my tree since for me autotools do not work with the current Makefile.am. I had to make a one line change but it is close to the place where I did other change so patch 9 might not apply cleanly. To avoid that I moved the lines around and generated a new version of patch 9. I hope it would apply cleanly.
Thanks for checking!
The save part will be done as a part of the fileobj API. It will include functions like:
- save backup in the given location
- change file ownership/permissions
- save file
I have not checked the code itself, I just noticed that "From" attribute is wrong. It says
From: Dmitri Pal dpal@dpal.csb
while it should rather say
From: Dmitri Pal dpal@redhat.com
to not spoil the git shortlog.
Martin
What should I do to fix it?
On 12/09/2014 04:00 PM, Dmitri Pal wrote:
On 12/09/2014 08:24 AM, Martin Kosek wrote:
...
I have not checked the code itself, I just noticed that "From" attribute is wrong. It says
From: Dmitri Pal dpal@dpal.csb
while it should rather say
From: Dmitri Pal dpal@redhat.com
to not spoil the git shortlog.
Martin
What should I do to fix it?
1) Set proper global git config with the right name. See
http://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup
part "Your Identity".
2) This only applies for new commits. To change existing ones, you would need to do sed s/old-mail/new-mail/ on the patches and re-import them to git or do some git magic like in section "Changing E-Mail Addresses Globally" in
http://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
I do not know some more convenient way, I mostly only need to do it for the last commit, in which case 'git commit --amend --author "new author"' is enough.
HTH, Martin
On 12/09/2014 02:18 PM, Martin Kosek wrote:
On 12/09/2014 04:00 PM, Dmitri Pal wrote:
On 12/09/2014 08:24 AM, Martin Kosek wrote:
...
I have not checked the code itself, I just noticed that "From" attribute is wrong. It says
From: Dmitri Pal dpal@dpal.csb
while it should rather say
From: Dmitri Pal dpal@redhat.com
to not spoil the git shortlog.
Martin
What should I do to fix it?
- Set proper global git config with the right name. See
http://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup
part "Your Identity".
I did that.
- This only applies for new commits. To change existing ones, you
would need to do sed s/old-mail/new-mail/ on the patches and re-import them to git or do some git magic like in section "Changing E-Mail Addresses Globally" in
http://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
I do not know some more convenient way, I mostly only need to do it for the last commit, in which case 'git commit --amend --author "new author"' is enough.
I did this (but I figured it out myself) :-P http://makandracards.com/makandra/1717-git-change-author-of-a-commit
HTH, Martin
On (08/12/14 14:19), Dmitri Pal wrote:
On 12/08/2014 01:10 PM, Pavel Březina wrote:
On 12/08/2014 10:46 AM, Jakub Hrozek wrote:
On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
On 12/07/2014 05:32 PM, Dmitri Pal wrote:
Hello,
First three patches introduce changes to collection that were needed for the implementation of the INI object modification API The rest are for the INI itself. I made recommended changes and cleaned doxygen comments a bit.
The INI interface so far does not include: a) Saving to file - function requested by Pavel b) Sorting
I plan to provide this functionality in the follow up patches.
Cleaned couple things. This is a better set
Pavel, can you check if the API would allow you to use libini_config instead of augeas?
For some reason the patches are not directly applicable by git. I had to remove the first character '>' from each patch before applying. After that, it cannot be applied to the ding-libs master, it fails with:
error: patch failed: Makefile.am:251 error: Makefile.am: patch does not apply Patch failed at 0009 Build new interface
Are those patches dependent on some other patches?
Anyway, the interface should be good. I guess that the only thing I am missing from augeas functionality is the save function.
I am puzzled how ">" ended up in all the patches. I regenerated a new set and there is no ">" there.
Also you are right. I have a patch that is in my tree since for me autotools do not work with the current Makefile.am. I had to make a one line change but it is close to the place where I did other change so patch 9 might not apply cleanly. To avoid that I moved the lines around and generated a new version of patch 9. I hope it would apply cleanly.
Thanks for checking!
The save part will be done as a part of the fileobj API. It will include functions like:
- save backup in the given location
- change file ownership/permissions
- save file
-- Thank you, Dmitri Pal
Sr. Engineering Manager IdM portfolio Red Hat, Inc.
Just for the record Patches from this thread are supperseded by paches from thread [1] "[INI] Patches for the INI configuration modification"
LS
[1] https://lists.fedorahosted.org/pipermail/sssd-devel/2015-January/022087.html
sssd-devel@lists.fedorahosted.org
-
Dmitri Pal -
Jakub Hrozek -
Lukas Slebodnik -
Martin Kosek -
Pavel Březina