[PATCH] Fix czech specific character in my name

[Pavel Březina]

Hi,
I just noticed that 'ř' character from my name got somehow messed up
during push. I'd like to get this fixed.

I know I could just play nice with the ASCII world and use 'r', but 
frankly, it wouldn't be my name and I don't like it :-)

[Jakub Hrozek]

On Mon, Sep 02, 2013 at 01:27:17PM +0200, Pavel Březina wrote:
> Hi,
> I just noticed that 'ř' character from my name got somehow messed up
> during push. I'd like to get this fixed.
>
> I know I could just play nice with the ASCII world and use 'r', but
> frankly, it wouldn't be my name and I don't like it :-)

They both display as "??" to me in vim..

Also the git pager has trouble seeing any changes:
$ git show -1
commit 1e91fcde47feb3a3c54a6dd01474fcbbf566015d
Author: Pavel Březina 
Date:   Mon Sep 2 13:22:10 2013 +0200

Fix czech specific character in my name

[Sumit Bose]

On Mon, Sep 02, 2013 at 02:20:42PM +0200, Jakub Hrozek wrote:
> On Mon, Sep 02, 2013 at 01:27:17PM +0200, Pavel Březina wrote:
> > Hi,
> > I just noticed that 'ř' character from my name got somehow messed up
> > during push. I'd like to get this fixed.
> >
> > I know I could just play nice with the ASCII world and use 'r', but
> > frankly, it wouldn't be my name and I don't like it :-)
>
> They both display as "??" to me in vim..

I cannot confirm this. I see vin correctly showing 'ř' in the + lines
while the - lines have ??.
> Also the git pager has trouble seeing any changes:
> $ git show -1
> commit 1e91fcde47feb3a3c54a6dd01474fcbbf566015d
> Author: Pavel Březina 
> Date:   Mon Sep 2 13:22:10 2013 +0200
> Fix czech specific character in my name

I see:

commit b0e9d4dd50ec7703c3660a40fcec12ab6721180c
Author: Pavel Březina 
Date:   Mon Sep 2 13:22:10 2013 +0200

Fix czech specific character in my name

diff --git a/src/providers/ad/ad_srv.c b/src/providers/ad/ad_srv.c
index 861ae3d..4ae91f0 100644
--- a/src/providers/ad/ad_srv.c
+++ b/src/providers/ad/ad_srv.c
@@ -1,6 +1,6 @@
 /*
     Authors:
-        Pavel B??ezina 
+        Pavel Březina

Copyright (C) 2013 Red Hat

diff --git a/src/providers/ad/ad_srv.h b/src/providers/ad/ad_srv.h
index adf29b0..7522eca 100644
--- a/src/providers/ad/ad_srv.h
+++ b/src/providers/ad/ad_srv.h
@@ -1,6 +1,6 @@
 /*
     Authors:
-        Pavel B??ezina 
+        Pavel Březina

Copyright (C) 2013 Red Hat

...

bye,
Sumit
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Mon, Sep 02, 2013 at 02:44:23PM +0200, Sumit Bose wrote:
> On Mon, Sep 02, 2013 at 02:20:42PM +0200, Jakub Hrozek wrote:
> > On Mon, Sep 02, 2013 at 01:27:17PM +0200, Pavel Březina wrote:
> > > Hi,
> > > I just noticed that 'ř' character from my name got somehow messed up
> > > during push. I'd like to get this fixed.
> > >
> > > I know I could just play nice with the ASCII world and use 'r', but
> > > frankly, it wouldn't be my name and I don't like it :-)
> >
> > They both display as "??" to me in vim..
>
> I cannot confirm this. I see vin correctly showing 'ř' in the + lines
> while the - lines have ??.
> > Also the git pager has trouble seeing any changes:
> > $ git show -1
> > commit 1e91fcde47feb3a3c54a6dd01474fcbbf566015d
> > Author: Pavel Březina 
> > Date:   Mon Sep 2 13:22:10 2013 +0200
> > Fix czech specific character in my name
>
> I see:
>
> commit b0e9d4dd50ec7703c3660a40fcec12ab6721180c
> Author: Pavel Březina 
> Date:   Mon Sep 2 13:22:10 2013 +0200
> Fix czech specific character in my name
>
> diff --git a/src/providers/ad/ad_srv.c b/src/providers/ad/ad_srv.c
> index 861ae3d..4ae91f0 100644
> --- a/src/providers/ad/ad_srv.c
> +++ b/src/providers/ad/ad_srv.c
> @@ -1,6 +1,6 @@
>  /*
>      Authors:
>    Pavel B??ezina <[e-mail]>
>    Pavel Březina <[e-mail]>
>
> Copyright (C) 2013 Red Hat
>
> diff --git a/src/providers/ad/ad_srv.h b/src/providers/ad/ad_srv.h
> index adf29b0..7522eca 100644
> --- a/src/providers/ad/ad_srv.h
> +++ b/src/providers/ad/ad_srv.h
> @@ -1,6 +1,6 @@
>  /*
>      Authors:
>    Pavel B??ezina <[e-mail]>
>    Pavel Březina <[e-mail]>
>
> Copyright (C) 2013 Red Hat
>
> ...
>
> bye,
> Sumit

Interesting..well, if it works for you, then I assume it must be some
misconfiguration on my end. Btw I use en_US.UTF-8, but that shouldn't
prevent me from displaying UTF8 characters (I see "Březina" in the reply
you quoted..)

[Jakub Hrozek]

On Mon, Sep 02, 2013 at 02:56:06PM +0200, Jakub Hrozek wrote:
> On Mon, Sep 02, 2013 at 02:44:23PM +0200, Sumit Bose wrote:
> > On Mon, Sep 02, 2013 at 02:20:42PM +0200, Jakub Hrozek wrote:
> > > On Mon, Sep 02, 2013 at 01:27:17PM +0200, Pavel Březina wrote:
> > > > Hi,
> > > > I just noticed that 'ř' character from my name got somehow messed up
> > > > during push. I'd like to get this fixed.
> > > >
> > > > I know I could just play nice with the ASCII world and use 'r', but
> > > > frankly, it wouldn't be my name and I don't like it :-)
> > >
> > > They both display as "??" to me in vim..
> >
> > I cannot confirm this. I see vin correctly showing 'ř' in the + lines
> > while the - lines have ??.
> > > Also the git pager has trouble seeing any changes:
> > > $ git show -1
> > > commit 1e91fcde47feb3a3c54a6dd01474fcbbf566015d
> > > Author: Pavel Březina 
> > > Date:   Mon Sep 2 13:22:10 2013 +0200
> > > Fix czech specific character in my name
> >
> > I see:
> >
> > commit b0e9d4dd50ec7703c3660a40fcec12ab6721180c
> > Author: Pavel Březina 
> > Date:   Mon Sep 2 13:22:10 2013 +0200
> > Fix czech specific character in my name
> >
> > diff --git a/src/providers/ad/ad_srv.c b/src/providers/ad/ad_srv.c
> > index 861ae3d..4ae91f0 100644
> > --- a/src/providers/ad/ad_srv.c
> > +++ b/src/providers/ad/ad_srv.c
> > @@ -1,6 +1,6 @@
> >  /*
> >      Authors:
> >    Pavel B??ezina <[e-mail]>
> >    Pavel Březina <[e-mail]>
> >
> > Copyright (C) 2013 Red Hat
> >
> > diff --git a/src/providers/ad/ad_srv.h b/src/providers/ad/ad_srv.h
> > index adf29b0..7522eca 100644
> > --- a/src/providers/ad/ad_srv.h
> > +++ b/src/providers/ad/ad_srv.h
> > @@ -1,6 +1,6 @@
> >  /*
> >      Authors:
> >    Pavel B??ezina <[e-mail]>
> >    Pavel Březina <[e-mail]>
> >
> > Copyright (C) 2013 Red Hat
> >
> > ...
> >
> > bye,
> > Sumit
>
> Interesting..well, if it works for you, then I assume it must be some
> misconfiguration on my end. Btw I use en_US.UTF-8, but that shouldn't
> prevent me from displaying UTF8 characters (I see "Březina" in the reply
> you quoted..)

There must be something wrong with my mutt setup. When I downloaded the
patch from Zimbra UI, it displayed fine.

So ACK from me, too.

[Jakub Hrozek]

On Mon, Sep 02, 2013 at 03:13:10PM +0200, Jakub Hrozek wrote:
> On Mon, Sep 02, 2013 at 02:56:06PM +0200, Jakub Hrozek wrote:
> > On Mon, Sep 02, 2013 at 02:44:23PM +0200, Sumit Bose wrote:
> > > On Mon, Sep 02, 2013 at 02:20:42PM +0200, Jakub Hrozek wrote:
> > > > On Mon, Sep 02, 2013 at 01:27:17PM +0200, Pavel Březina wrote:
> > > > > Hi,
> > > > > I just noticed that 'ř' character from my name got somehow messed up
> > > > > during push. I'd like to get this fixed.
> > > > >
> > > > > I know I could just play nice with the ASCII world and use 'r', but
> > > > > frankly, it wouldn't be my name and I don't like it :-)
> > > >
> > > > They both display as "??" to me in vim..
> > >
> > > I cannot confirm this. I see vin correctly showing 'ř' in the + lines
> > > while the - lines have ??.
> > > > Also the git pager has trouble seeing any changes:
> > > > $ git show -1
> > > > commit 1e91fcde47feb3a3c54a6dd01474fcbbf566015d
> > > > Author: Pavel Březina 
> > > > Date:   Mon Sep 2 13:22:10 2013 +0200
> > > > Fix czech specific character in my name
> > >
> > > I see:
> > >
> > > commit b0e9d4dd50ec7703c3660a40fcec12ab6721180c
> > > Author: Pavel Březina 
> > > Date:   Mon Sep 2 13:22:10 2013 +0200
> > > Fix czech specific character in my name
> > >
> > > diff --git a/src/providers/ad/ad_srv.c b/src/providers/ad/ad_srv.c
> > > index 861ae3d..4ae91f0 100644
> > > --- a/src/providers/ad/ad_srv.c
> > > +++ b/src/providers/ad/ad_srv.c
> > > @@ -1,6 +1,6 @@
> > >  /*
> > >      Authors:
> > >    Pavel B??ezina <[e-mail]>
> > >    Pavel Březina <[e-mail]>
> > >
> > > Copyright (C) 2013 Red Hat
> > >
> > > diff --git a/src/providers/ad/ad_srv.h b/src/providers/ad/ad_srv.h
> > > index adf29b0..7522eca 100644
> > > --- a/src/providers/ad/ad_srv.h
> > > +++ b/src/providers/ad/ad_srv.h
> > > @@ -1,6 +1,6 @@
> > >  /*
> > >      Authors:
> > >    Pavel B??ezina <[e-mail]>
> > >    Pavel Březina <[e-mail]>
> > >
> > > Copyright (C) 2013 Red Hat
> > >
> > > ...
> > >
> > > bye,
> > > Sumit
> >
> > Interesting..well, if it works for you, then I assume it must be some
> > misconfiguration on my end. Btw I use en_US.UTF-8, but that shouldn't
> > prevent me from displaying UTF8 characters (I see "Březina" in the reply
> > you quoted..)
>
> There must be something wrong with my mutt setup. When I downloaded the
> patch from Zimbra UI, it displayed fine.
>
> So ACK from me, too.

Pushed to master.

After Sumit's advice I started using "set assumed_charset = utf-8" in my
.muttrc and everything works now.