ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
1) Why not just move the file ownership to sssd-common? Are you concerned that not everyone needs sudo and it would be an extra file on the filesystem?
2) The src/sss_client/sudo/sss_sudo.c only lists GPLv3, not LGPLv3, are you sure adding the lesser copying is correct?
3) I think this is a good opportunity to move the library outside libdir, at least in F-24 (this would require coordination with sudo and adding versioned Requires)
On (11/01/16 10:26), Jakub Hrozek wrote:
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
- Why not just move the file ownership to sssd-common? Are you
concerned that not everyone needs sudo and it would be an extra file on the filesystem?
It was in sssd-common but it should be moved outside. I dnifn't notice I forgot to do that :-)
- The src/sss_client/sudo/sss_sudo.c only lists GPLv3, not LGPLv3, are
you sure adding the lesser copying is correct?
I didn't check header of file. I used the same license as in was in 1.9.x Fixed.
- I think this is a good opportunity to move the library outside
libdir, at least in F-24 (this would require coordination with sudo and adding versioned Requires)
They are unrelated changes and shoudl be discussed with sudo maintainer. BTW atm sssd-common(and thus libsss_sudo.so) does not depend on sudo.
Updated patch is attached.
LS
On Mon, Jan 11, 2016 at 12:22:19PM +0100, Lukas Slebodnik wrote:
On (11/01/16 10:26), Jakub Hrozek wrote:
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
- Why not just move the file ownership to sssd-common? Are you
concerned that not everyone needs sudo and it would be an extra file on the filesystem?
It was in sssd-common but it should be moved outside. I dnifn't notice I forgot to do that :-)
Ah, sorry, I meant sssd-client here, not sssd-common...since client would have to be installed anyway in the containerized environments and the size of the sudo package is just 20kBs..
- The src/sss_client/sudo/sss_sudo.c only lists GPLv3, not LGPLv3, are
you sure adding the lesser copying is correct?
I didn't check header of file. I used the same license as in was in 1.9.x Fixed.
- I think this is a good opportunity to move the library outside
libdir, at least in F-24 (this would require coordination with sudo and adding versioned Requires)
They are unrelated changes and shoudl be discussed with sudo maintainer.
indeed it needs to be discussed, but isn't it a good time now when F-24 is in its early development.
BTW atm sssd-common(and thus libsss_sudo.so) does not depend on sudo.
Yes, but we would have to add a versioned dependency to the sudo side to make sure the libsss_sudo it would pull would be the one that carries the expected location of libsss_sudo..
On 01/11/2016 12:53 PM, Jakub Hrozek wrote:
On Mon, Jan 11, 2016 at 12:22:19PM +0100, Lukas Slebodnik wrote:
On (11/01/16 10:26), Jakub Hrozek wrote:
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
- Why not just move the file ownership to sssd-common? Are you
concerned that not everyone needs sudo and it would be an extra file on the filesystem?
It was in sssd-common but it should be moved outside. I dnifn't notice I forgot to do that :-)
Ah, sorry, I meant sssd-client here, not sssd-common...since client would have to be installed anyway in the containerized environments and the size of the sudo package is just 20kBs..
- The src/sss_client/sudo/sss_sudo.c only lists GPLv3, not LGPLv3, are
you sure adding the lesser copying is correct?
I didn't check header of file. I used the same license as in was in 1.9.x Fixed.
- I think this is a good opportunity to move the library outside
libdir, at least in F-24 (this would require coordination with sudo and adding versioned Requires)
They are unrelated changes and shoudl be discussed with sudo maintainer.
indeed it needs to be discussed, but isn't it a good time now when F-24 is in its early development.
We should wait with this change. One BZ requires changing the sudo protocol we use and thus there will be bigger changes in sudo itself. We will do it at once.
https://fedorahosted.org/sssd/ticket/2919
BTW atm sssd-common(and thus libsss_sudo.so) does not depend on sudo.
Yes, but we would have to add a versioned dependency to the sudo side to make sure the libsss_sudo it would pull would be the one that carries the expected location of libsss_sudo.. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
On (11/01/16 13:38), Pavel Březina wrote:
On 01/11/2016 12:53 PM, Jakub Hrozek wrote:
On Mon, Jan 11, 2016 at 12:22:19PM +0100, Lukas Slebodnik wrote:
On (11/01/16 10:26), Jakub Hrozek wrote:
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
- Why not just move the file ownership to sssd-common? Are you
concerned that not everyone needs sudo and it would be an extra file on the filesystem?
It was in sssd-common but it should be moved outside. I dnifn't notice I forgot to do that :-)
Ah, sorry, I meant sssd-client here, not sssd-common...since client would have to be installed anyway in the containerized environments and the size of the sudo package is just 20kBs..
- The src/sss_client/sudo/sss_sudo.c only lists GPLv3, not LGPLv3, are
you sure adding the lesser copying is correct?
I didn't check header of file. I used the same license as in was in 1.9.x Fixed.
- I think this is a good opportunity to move the library outside
libdir, at least in F-24 (this would require coordination with sudo and adding versioned Requires)
They are unrelated changes and shoudl be discussed with sudo maintainer.
indeed it needs to be discussed, but isn't it a good time now when F-24 is in its early development.
We should wait with this change. One BZ requires changing the sudo protocol we use and thus there will be bigger changes in sudo itself. We will do it at once.
OK,
I updated blocked by nd blocking attributes in related tickets
LS
On (11/01/16 12:53), Jakub Hrozek wrote:
On Mon, Jan 11, 2016 at 12:22:19PM +0100, Lukas Slebodnik wrote:
On (11/01/16 10:26), Jakub Hrozek wrote:
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
- Why not just move the file ownership to sssd-common? Are you
concerned that not everyone needs sudo and it would be an extra file on the filesystem?
It was in sssd-common but it should be moved outside. I dnifn't notice I forgot to do that :-)
Ah, sorry, I meant sssd-client here, not sssd-common...since client would have to be installed anyway in the containerized environments and the size of the sudo package is just 20kBs..
I think it's explained in commit message or should I ellaborate?
LS
On Mon, Jan 11, 2016 at 02:51:24PM +0100, Lukas Slebodnik wrote:
On (11/01/16 12:53), Jakub Hrozek wrote:
On Mon, Jan 11, 2016 at 12:22:19PM +0100, Lukas Slebodnik wrote:
On (11/01/16 10:26), Jakub Hrozek wrote:
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
- Why not just move the file ownership to sssd-common? Are you
concerned that not everyone needs sudo and it would be an extra file on the filesystem?
It was in sssd-common but it should be moved outside. I dnifn't notice I forgot to do that :-)
Ah, sorry, I meant sssd-client here, not sssd-common...since client would have to be installed anyway in the containerized environments and the size of the sudo package is just 20kBs..
I think it's explained in commit message or should I ellaborate?
I must admit I didn't read it and yes, it's clear now, thanks.
I'll proceed to patch review..
On Mon, Jan 11, 2016 at 12:22:19PM +0100, Lukas Slebodnik wrote:
On (11/01/16 10:26), Jakub Hrozek wrote:
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
- Why not just move the file ownership to sssd-common? Are you
concerned that not everyone needs sudo and it would be an extra file on the filesystem?
It was in sssd-common but it should be moved outside. I dnifn't notice I forgot to do that :-)
- The src/sss_client/sudo/sss_sudo.c only lists GPLv3, not LGPLv3, are
you sure adding the lesser copying is correct?
I didn't check header of file. I used the same license as in was in 1.9.x Fixed.
- I think this is a good opportunity to move the library outside
libdir, at least in F-24 (this would require coordination with sudo and adding versioned Requires)
They are unrelated changes and shoudl be discussed with sudo maintainer. BTW atm sssd-common(and thus libsss_sudo.so) does not depend on sudo.
Updated patch is attached.
LS
From 32b9f09e54f71747bf7d9efc00e36df12ee0640c Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Wed, 6 Jan 2016 16:32:55 +0100 Subject: [PATCH] SPEC: Move libsss_sudo.so outside sssd-common
The module ${libdir}/libsss_sudo.so is used only by /usr/bin/sudo. If libsss_sudo.so was part of sssd-client then 32 bit version would never be used on 64 bit machine and files in sssd-client can be used by multilib applications e.g. libnss_sss.so can be indirectly "dlopened" by 64 bit applications and 32 bit application. (32-bit web browser; ordinary 64bit applications ...)
Resolves: https://fedorahosted.org/sssd/ticket/2855 (cherry picked from commit 64c256abfaa4377e995eff505b0fd9f10215113e)
ACK
the patch looks good and upgrade pulls in libsss-common
On (14/01/16 11:20), Jakub Hrozek wrote:
On Mon, Jan 11, 2016 at 12:22:19PM +0100, Lukas Slebodnik wrote:
On (11/01/16 10:26), Jakub Hrozek wrote:
On Wed, Jan 06, 2016 at 04:48:00PM +0100, Lukas Slebodnik wrote:
ehlo,
This change is required to reduce dependency tree in client container (or on atomic host, ...)
Patch is attached.
LS
I have some questions..
- Why not just move the file ownership to sssd-common? Are you
concerned that not everyone needs sudo and it would be an extra file on the filesystem?
It was in sssd-common but it should be moved outside. I dnifn't notice I forgot to do that :-)
- The src/sss_client/sudo/sss_sudo.c only lists GPLv3, not LGPLv3, are
you sure adding the lesser copying is correct?
I didn't check header of file. I used the same license as in was in 1.9.x Fixed.
- I think this is a good opportunity to move the library outside
libdir, at least in F-24 (this would require coordination with sudo and adding versioned Requires)
They are unrelated changes and shoudl be discussed with sudo maintainer. BTW atm sssd-common(and thus libsss_sudo.so) does not depend on sudo.
Updated patch is attached.
LS
From 32b9f09e54f71747bf7d9efc00e36df12ee0640c Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lslebodn@redhat.com Date: Wed, 6 Jan 2016 16:32:55 +0100 Subject: [PATCH] SPEC: Move libsss_sudo.so outside sssd-common
The module ${libdir}/libsss_sudo.so is used only by /usr/bin/sudo. If libsss_sudo.so was part of sssd-client then 32 bit version would never be used on 64 bit machine and files in sssd-client can be used by multilib applications e.g. libnss_sss.so can be indirectly "dlopened" by 64 bit applications and 32 bit application. (32-bit web browser; ordinary 64bit applications ...)
Resolves: https://fedorahosted.org/sssd/ticket/2855 (cherry picked from commit 64c256abfaa4377e995eff505b0fd9f10215113e)
ACK
the patch looks good and upgrade pulls in libsss-common
master: * 5e532ad5c1326c68caa4914c43663677dabf03b3
LS
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Pavel Březina