[PATCH][ding-libs] SPEC: path-utils unit test requires libcheck

[Lukas Slebodnik]

ehlo,

And this is 2nd problem I found yesterday.
Simple patch is attached.

LS

[Jakub Hrozek]

On Tue, Jan 21, 2014 at 09:45:19AM +0100, Lukas Slebodnik wrote:
>  ehlo,
>  
>  And this is 2nd problem I found yesterday.
>  Simple patch is attached.
>  
>  LS 
ACK

pkgconfig is dragged in as a dependency of some other package:
http://kojipkgs.fedoraproject.org//packages/ding-libs/0.3.0.1/21.fc21/dat...

but it's better to BuildRequire it explicitly.

check-devel was BuildRequired in Fedora, but not in upstream. I think it
must have been because upstream was supporting RHEL5 until recently and
I don't think check was available there.

[Jakub Hrozek]

On Wed, Jan 22, 2014 at 11:39:18PM +0100, Jakub Hrozek wrote:
>  On Tue, Jan 21, 2014 at 09:45:19AM +0100, Lukas Slebodnik wrote:
>  > ehlo,
>  > 
>  > And this is 2nd problem I found yesterday.
>  > Simple patch is attached.
>  > 
>  > LS
>  
>  ACK
>  
>  pkgconfig is dragged in as a dependency of some other package:
>
> http://kojipkgs.fedoraproject.org//packages/ding-libs/0.3.0.1/21.fc21/dat...
>  
>  but it's better to BuildRequire it explicitly.
>  
>  check-devel was BuildRequired in Fedora, but not in upstream. I think it
>  must have been because upstream was supporting RHEL5 until recently and
>  I don't think check was available there. 
Pushed to ding-libs master.

[Lukas Slebodnik]

On (22/01/14 23:39), Jakub Hrozek wrote:
> On Tue, Jan 21, 2014 at 09:45:19AM +0100, Lukas Slebodnik wrote:
> > ehlo,
> > 
> > And this is 2nd problem I found yesterday.
> > Simple patch is attached.
> > 
> > LS
>
> ACK
>
> pkgconfig is dragged in as a dependency of some other package:
> http://kojipkgs.fedoraproject.org//packages/ding-libs/0.3.0.1/21.fc21/dat...
>
> but it's better to BuildRequire it explicitly. 
I added it explicitly, because I
inspired in sssd.spec file.
> check-devel was BuildRequired in Fedora, but not in upstream. I think it
> must have been because upstream was supporting RHEL5 until recently and
> I don't think check was available there. 
check-devel is available on RHEL5, but
contains only static library without
pkg-config file.

BTW ding-libs master can be built on RHEL5, but we should remove
autoreconf -ivf from spec file (or use condition 0%{?rhel} >= 5),
because there is bug in RHEL5 autotools.

LS

[Jakub Hrozek]

On Fri, Jan 24, 2014 at 06:48:23PM +0100, Lukas Slebodnik wrote:
>  On (22/01/14 23:39), Jakub Hrozek wrote:
>  >On Tue, Jan 21, 2014 at 09:45:19AM +0100, Lukas Slebodnik wrote:
>  >> ehlo,
>  >> 
>  >> And this is 2nd problem I found yesterday.
>  >> Simple patch is attached.
>  >> 
>  >> LS
>  >
>  >ACK
>  >
>  >pkgconfig is dragged in as a dependency of some other package:
>
> >http://kojipkgs.fedoraproject.org//packages/ding-libs/0.3.0.1/21.fc21/data/logs/x86_64/root.log
>  >
>  >but it's better to BuildRequire it explicitly.
>  I added it explicitly, because I inspired in sssd.spec file.
>  >
>  >check-devel was BuildRequired in Fedora, but not in upstream. I think it
>  >must have been because upstream was supporting RHEL5 until recently and
>  >I don't think check was available there.
>  check-devel is available on RHEL5, but contains only static library without
>  pkg-config file. 
Ah, perhaps. I only remember out configure time tests couldn't fine
check on RHEL5

>  
>  BTW ding-libs master can be built on RHEL5, but we should remove
>  autoreconf -ivf from spec file (or use condition 0%{?rhel} >= 5),
>  because there is bug in RHEL5 autotools.
>   
I don't think it's worth spending any time for development of new
upstream features on RHEL5. Not unless users explicitly ask for such
support.