2:35 p.m.
These two functions were almost identical. Better to maintain them
as a single function.
2:16 a.m.
On 07/28/2011 09:35 PM, Stephen Gallagher wrote:
These two functions were almost identical. Better to maintain them
as a single function.
In the old implementation, only accept_priv_fd_handler() used to set
cctx->priv = 1, now the converged implementation sets it unconditionally
for both cases, is that intentional?
8:21 a.m.
On Fri, 2011-07-29 at 09:16 +0200, Jakub Hrozek wrote:
On 07/28/2011 09:35 PM, Stephen Gallagher wrote:
> These two functions were almost identical. Better to maintain them
> as a single function.
>
In the old implementation, only accept_priv_fd_handler() used to set
cctx->priv = 1, now the converged implementation sets it unconditionally
for both cases, is that intentional?
Nope, that would have been a bug. New patch attached.
12:43 p.m.
On Fri, Jul 29, 2011 at 09:21:30AM -0400, Stephen Gallagher wrote:
On Fri, 2011-07-29 at 09:16 +0200, Jakub Hrozek wrote:
> On 07/28/2011 09:35 PM, Stephen Gallagher wrote:
> > These two functions were almost identical. Better to maintain them
> > as a single function.
> >
>
> In the old implementation, only accept_priv_fd_handler() used to set
> cctx->priv = 1, now the converged implementation sets it unconditionally
> for both cases, is that intentional?
Nope, that would have been a bug. New patch attached.
Ack
1:06 p.m.
On Fri, 2011-07-29 at 19:43 +0200, Jakub Hrozek wrote:
On Fri, Jul 29, 2011 at 09:21:30AM -0400, Stephen Gallagher wrote:
> On Fri, 2011-07-29 at 09:16 +0200, Jakub Hrozek wrote:
> > On 07/28/2011 09:35 PM, Stephen Gallagher wrote:
> > > These two functions were almost identical. Better to maintain them
> > > as a single function.
> > >
> >
> > In the old implementation, only accept_priv_fd_handler() used to set
> > cctx->priv = 1, now the converged implementation sets it unconditionally
> > for both cases, is that intentional?
>
> Nope, that would have been a bug. New patch attached.
>
Ack
Pushed to master.
4654
days inactive
4655
days old
sssd-devel@lists.fedorahosted.org
4 comments
2 participants
participants (2)
-
Jakub Hrozek -
Stephen Gallagher