[PATCH] Make ldap simple bind asynchronous

[Martin Nagy]

Hi,
here it is. I included some description in the commit log, it is
necessary to read it in order to understand why I did some things this
way. Any suggestions to make the patch better are most welcome.

Martin

[Martin Nagy]

On Fri, 2010-04-23 at 14:49 +0200, Martin Nagy wrote:
> Hi,
> here it is. I included some description in the commit log, it is
> necessary to read it in order to understand why I did some things this
> way. Any suggestions to make the patch better are most welcome.
>
> Martin

New patches after some comments from Simo on IRC. The comments were:

Allocate fd_event_item on cb_data and simply use destructor
appended to a memory context that depends on the request to
remove it.

Remove simple_bind_wakeup_op_add() and instead use a boolean
in state that simple_bind_wakeup_bind() checks first to see
what operation to do.

The tevent_req_post() in simple_bind_wakeup_op_add() shouldn't
be there.

My own: Add forgotten timeout.

Move ldap_finish_bind to sdap_async.c.

These were all fixed.

Martin

[Stephen Gallagher]

On 05/03/2010 12:29 PM, Martin Nagy wrote:
> On Fri, 2010-04-23 at 14:49 +0200, Martin Nagy wrote:
> > Hi,
> > here it is. I included some description in the commit log, it is
> > necessary to read it in order to understand why I did some things this
> > way. Any suggestions to make the patch better are most welcome.
> >
> > Martin
>
> New patches after some comments from Simo on IRC. The comments were:
>
> Allocate fd_event_item on cb_data and simply use destructor
> appended to a memory context that depends on the request to
> remove it.
>
> Remove simple_bind_wakeup_op_add() and instead use a boolean
> in state that simple_bind_wakeup_bind() checks first to see
> what operation to do.
>
> The tevent_req_post() in simple_bind_wakeup_op_add() shouldn't
> be there.
>
> My own: Add forgotten timeout.
>
> Move ldap_finish_bind to sdap_async.c.
>
> These were all fixed.
>
> Martin

Nack. Build fails on platforms with openldap < 2.4. (e.g. RHEL5)

providers/ldap/sdap_async_connection.c: In function 'simple_bind_step':
providers/ldap/sdap_async_connection.c:360: error: 'LDAP_X_CONNECTING' 
undeclared (first use in this function)
providers/ldap/sdap_async_connection.c:360: error: (Each undeclared 
identifier is reported only once
providers/ldap/sdap_async_connection.c:360: error: for each function it 
appears in.)