[PATCH] MAN: Fix a conversion of seconds to hours

[Lukas Slebodnik]

ehlo.

simple patch is attached.

BTW: Do we want to document that this interval in ipa is 3x shorter?
We could also change default value in ipa provider.

sh$ git grep ldap_purge_cache_timeout -- src/providers/
src/providers/ad/ad_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 10800 }, NULL_NUMBER },
src/providers/ipa/ipa_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 3600 }, NULL_NUMBER },
src/providers/ldap/ldap_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 10800 }, NULL_NUMBER },

LS

[Pavel Reichl]

On 09/01/2014 07:40 AM, Lukas Slebodnik wrote:
> ehlo.
>
> simple patch is attached.

Patch applies fine and SSSD builds without problem.
ACK
> BTW: Do we want to document that this interval in ipa is 3x shorter?
> We could also change default value in ipa provider.

I don't know the reason for different value in case of IPA provider, but 
I would keep it as it is. But I think you are right to document the 
difference.
> sh$ git grep ldap_purge_cache_timeout -- src/providers/
> src/providers/ad/ad_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 10800 }, NULL_NUMBER },
> src/providers/ipa/ipa_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 3600 }, NULL_NUMBER },
> src/providers/ldap/ldap_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 10800 }, NULL_NUMBER },
>
> LS
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Mon, Sep 01, 2014 at 10:37:42AM +0200, Pavel Reichl wrote:
> On 09/01/2014 07:40 AM, Lukas Slebodnik wrote:
> > ehlo.
> >
> > simple patch is attached.
>
> Patch applies fine and SSSD builds without problem.
> ACK
> > BTW: Do we want to document that this interval in ipa is 3x shorter?
> > We could also change default value in ipa provider.
>
> I don't know the reason for different value in case of IPA provider, but I
> would keep it as it is. But I think you are right to document the
> difference.
> > sh$ git grep ldap_purge_cache_timeout -- src/providers/
> > src/providers/ad/ad_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 10800 }, NULL_NUMBER },
> > src/providers/ipa/ipa_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 3600 }, NULL_NUMBER },

I would prefer to fix the default to match the man page. But in a
separate patch, please
> > src/providers/ldap/ldap_opts.h:    { "ldap_purge_cache_timeout", DP_OPT_NUMBER, { .number = 10800 }, NULL_NUMBER },
> >
> > LS
> >
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Mon, Sep 01, 2014 at 10:37:42AM +0200, Pavel Reichl wrote:
> On 09/01/2014 07:40 AM, Lukas Slebodnik wrote:
> > ehlo.
> >
> > simple patch is attached.
>
> Patch applies fine and SSSD builds without problem.
> ACK

* master: 0253df73a348344fc0ae4a9302374feefa6c9452