[PATCH] fix handling of filtersUsers in groups

[Sumit Bose]

Hi,

this patch fixes https://fedorahosted.org/sssd/ticket/108 .

I couldn't make up my mind if the output should contain the filtered
user or not (wheel:x:10:root,sgallagh or wheel:x:10:sgallagh), because I
think the handling of root is different from other user. With
provider=files root should be member of groups like wheel even if the
root user is filtered. In other configurations where certain user, e.g.
Administrator if your server is AD, shall be filtered, I think it is
expected that this user does not appear in a group.

So I added a new boolean parameter filterUsersInGroups and fixed the
original problem in fill_grent. I also removed some very old tab
indents.

bye,
Sumit

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/21/2009 11:09 AM, Sumit Bose wrote:
> Hi,
>
> this patch fixes https://fedorahosted.org/sssd/ticket/108 .
>
> I couldn't make up my mind if the output should contain the filtered
> user or not (wheel:x:10:root,sgallagh or wheel:x:10:sgallagh), because I
> think the handling of root is different from other user. With
> provider=files root should be member of groups like wheel even if the
> root user is filtered. In other configurations where certain user, e.g.
> Administrator if your server is AD, shall be filtered, I think it is
> expected that this user does not appear in a group.
>
> So I added a new boolean parameter filterUsersInGroups and fixed the
> original problem in fill_grent. I also removed some very old tab
> indents.
>
> bye,
> Sumit
>
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Ack

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkqOxvMACgkQeiVVYja6o6MGLgCdFVMA5ZQLYWAFNqHgx18jCUa8
> NUwAn3OlXjZOHJpPV2RGEJwRgFfJjQ4m
> =Y/07
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/21/2009 12:10 PM, Stephen Gallagher wrote:
> On 08/21/2009 11:09 AM, Sumit Bose wrote:
> > Hi,
> > this patch fixes https://fedorahosted.org/sssd/ticket/108 .
> > I couldn't make up my mind if the output should contain the filtered
> > user or not (wheel:x:10:root,sgallagh or wheel:x:10:sgallagh), because I
> > think the handling of root is different from other user. With
> > provider=files root should be member of groups like wheel even if the
> > root user is filtered. In other configurations where certain user, e.g.
> > Administrator if your server is AD, shall be filtered, I think it is
> > expected that this user does not appear in a group.
> > So I added a new boolean parameter filterUsersInGroups and fixed the
> > original problem in fill_grent. I also removed some very old tab
> > indents.
> > bye,
> > Sumit
> >
> > sssd-devel mailing list
> > [e-mail]
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
>
> Ack

Pushed to master.
_______________________________________________
sssd-devel mailing list
[e-mail]
https://fedorahosted.org/mailman/listinfo/sssd-devel

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkqO0fQACgkQeiVVYja6o6MNzwCeJjK/1woqZ6opt4QIKDnk8RxQ
> fxUAniLAp/IgMa6u5izTvqGwB9mKS7be
> =2cBj
> -----END PGP SIGNATURE-----