8:08 a.m.
URL: https://github.com/SSSD/sssd/pull/5934
Author: alexey-tikhonov
Title: #5934: Removed unused file.
Action: opened
PR body:
"""
None
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5934/head:pr5934
git checkout pr5934
9:32 a.m.
New subject: [sssd PR#5934][+Waiting for review] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
Label: +Waiting for review
6:37 p.m.
New subject: [sssd PR#5934][comment] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
elkoniu commented:
"""
LGTM, one question: do you think we should mention in the commit message the reason why
file is unused / reason why it is deprecated? I can see that original commits points back
to 2009 and it looks like this piece of code has been deprecated due to later refactorings
and architecture changes.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5934#issuecomment-1003806460
6:37 p.m.
New subject: [sssd PR#5934][-Waiting for review] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
Label: -Waiting for review
6:37 p.m.
New subject: [sssd PR#5934][+Accepted] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
Label: +Accepted
7:18 a.m.
New subject: [sssd PR#5934][comment] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
alexey-tikhonov commented:
"""
LGTM, one question: do you think we should mention in the commit
message the reason why file is unused / reason why it is deprecated? I can see that
original commits points back to 2009 and it looks like this piece of code has been
deprecated due to later refactorings and architecture changes.
I believe this is a leftover of "sbus" code refactoring.
This file wasn't even compiled (or anyhow used) for a few years. Maybe not even
included in source tarball. I don't think anyone cares / notices it's removed from
upstream repo.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5934#issuecomment-1004086143
9:39 a.m.
New subject: [sssd PR#5934][comment] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
elkoniu commented:
"""
Thank you, I agree with you. LGTM
"""
See the full comment at https://github.com/SSSD/sssd/pull/5934#issuecomment-1004176225
9:46 a.m.
New subject: [sssd PR#5934][comment] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
ikerexxe commented:
"""
LGTM! Thanks for taking care of it.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5934#issuecomment-1005841714
9:48 a.m.
New subject: [sssd PR#5934][+Ready to push] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
Label: +Ready to push
9:49 a.m.
New subject: [sssd PR#5934][comment] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
alexey-tikhonov commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5934
* `master`
* 28af1752a8ba4d81ec3c6046d597f2c19d4d4755 - Removed unused file.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5934#issuecomment-1005844328
9:49 a.m.
New subject: [sssd PR#5934][+Pushed] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
Label: +Pushed
9:49 a.m.
New subject: [sssd PR#5934][-Accepted] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
Label: -Accepted
9:49 a.m.
New subject: [sssd PR#5934][-Ready to push] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Title: #5934: Removed unused file.
Label: -Ready to push
9:49 a.m.
New subject: [sssd PR#5934][closed] Removed unused file.
URL: https://github.com/SSSD/sssd/pull/5934
Author: alexey-tikhonov
Title: #5934: Removed unused file.
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5934/head:pr5934
git checkout pr5934
853
days inactive
861
days old
sssd-devel@lists.fedorahosted.org
13 comments
3 participants
participants (3)
-
alexey-tikhonov -
elkoniu
-
ikerexxe