[sssd PR#719][opened] ifp: extraAttributes is UnknownProperty

[thalman]

URL: https://github.com/SSSD/sssd/pull/719
Author: thalman
 Title: #719: ifp: extraAttributes is UnknownProperty
Action: opened

PR body:
"""
Attempting to get extraAttributes via SSSD's ifp fails.

Here I uncomment interface function for extraAttributes.
also right for querying this interface is changed to allow
this request.

Resolves:
https://pagure.io/SSSD/sssd/issue/3906
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/719/head:pr719
git checkout pr719

[sssd PR#719][comment] ifp: extraAttributes is UnknownProperty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

jhrozek commented:
"""
Can you also amend the ifp-test unit test?
```
./ifp_tests
[==========] Running 4 test(s).
[ RUN      ] test_el_to_dict
[       OK ] test_el_to_dict
[ RUN      ] test_attr_acl
[  ERROR   ] --- s2[i]
[   LINE   ] --- /home/jhrozek/devel/sssd/src/tests/cmocka/test_ifp.c:117: error: Failure!
[  FAILED  ] test_attr_acl
[ RUN      ] test_attr_acl_ex
[       OK ] test_attr_acl_ex
[ RUN      ] test_attr_allowed
[       OK ] test_attr_allowed
[==========] 4 test(s) run.
[  PASSED  ] 3 test(s).
[  FAILED  ] 1 test(s), listed below:
[  FAILED  ] test_attr_acl

1 FAILED TEST(S)
```

I think the extraAttributes piece should be just added to the list..
"""

See the full comment at https://github.com/SSSD/sssd/pull/719#issuecomment-448352926

[sssd PR#719][+Changes requested] ifp: extraAttributes is UnknownProperty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

Label: +Changes requested

[sssd PR#719][synchronized] ifp: extraAttributes is UnknownProperty

[thalman]

URL: https://github.com/SSSD/sssd/pull/719
Author: thalman
 Title: #719: ifp: extraAttributes is UnknownProperty
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/719/head:pr719
git checkout pr719

[sssd PR#719][-Changes requested] ifp: extraAttributes is UnknownProperty

[thalman]

URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

Label: -Changes requested

[sssd PR#719][comment] ifp: extraAttributes is UnknownProperty

[thalman]

URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

thalman commented:
"""
Fixed test
"""

See the full comment at https://github.com/SSSD/sssd/pull/719#issuecomment-450834868

[sssd PR#719][comment] ifp: extraAttributes is UnknownProperty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

jhrozek commented:
"""
Ack, an integration test was submitted in PR #726
"""

See the full comment at https://github.com/SSSD/sssd/pull/719#issuecomment-451461413

[sssd PR#719][+Accepted] ifp: extraAttributes is UnknownProperty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

Label: +Accepted

[sssd PR#719][comment] ifp: extraAttributes is UnknownProperty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

jhrozek commented:
"""
* master: 814889a7f4691a135b617058c3ae876b54d5b226
"""

See the full comment at https://github.com/SSSD/sssd/pull/719#issuecomment-451766830

[sssd PR#719][+Pushed] ifp: extraAttributes is UnknownProperty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

Label: +Pushed

[sssd PR#719][closed] ifp: extraAttributes is UnknownProperty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/719
Author: thalman
 Title: #719: ifp: extraAttributes is UnknownProperty
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/719/head:pr719
git checkout pr719