[sssd PR#386][opened] intg: prevent "TypeError: must be type, not classobj"

[amitkumar50]

URL: https://github.com/SSSD/sssd/pull/386
Author: amitkumar50
 Title: #386: intg: prevent "TypeError: must be type, not classobj"
Action: opened

PR body:
"""
Changes
- src/config/SSSDConfig/ipachangeconf.py:class IPAChangeConf:
- src/sbus/sbus_codegen:class Base:
- src/sbus/sbus_codegen:class DBusXMLParser:

Resolves: https://pagure.io/SSSD/sssd/issue/3517
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/386/head:pr386
git checkout pr386

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[centos-ci]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-330191441

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[centos-ci]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-330191442

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[fidencio]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

fidencio commented:
"""
ok to test
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-330192709

[sssd PR#386][+Accepted] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

Label: +Accepted

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

lslebodn commented:
"""
ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-330197646

[sssd PR#386][-Accepted] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

Label: -Accepted

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

lslebodn commented:
"""
Code wise ACK, but I noticed unrelated commit title before pushing.
@amitkumar50 it has nothing to do with integration test (prefix intg) and there is not any error
"TypeError: must be type, not classobj". Because nobody tried to inherit form these object and use super. It is related to old style classes and new style clases.

More in following links and you can find even more on net
https://docs.python.org/release/2.2.3/whatsnew/sect-rellinks.html
https://stackoverflow.com/questions/54867/what-is-the-difference-between-old...

"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-330222288

[sssd PR#386][+Changes requested] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

Label: +Changes requested

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[amitkumar50]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

amitkumar50 commented:
"""
@fidencio So Would this PR title be suitable:
`Changing class declaration from old to new-style type.`
Or what title you would have..
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-330826733

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[fidencio]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

fidencio commented:
"""
@amitkumar50, I guess @lslebodn is the right person to answer as he has been reviewing this PR. :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-330827790

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[amitkumar50]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

amitkumar50 commented:
"""
@lslebodn waiting for your comments..
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-331837047

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

lslebodn commented:
"""
"python: Changing class declaration from old to new-style type"
sounds good to me

"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-331868285

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

jhrozek commented:
"""
@amitkumar50 can you please change the title of this PR so that we can push the patch? Thank you!
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-332621455

[sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

lslebodn commented:
"""
Title changed (due to timeout :-) and pushed

master:
* b07852825eeb63a78e1b3863e42b3f328430da18
"""

See the full comment at https://github.com/SSSD/sssd/pull/386#issuecomment-334067491

[sssd PR#386][closed] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Author: amitkumar50
 Title: #386: intg: prevent "TypeError: must be type, not classobj"
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/386/head:pr386
git checkout pr386

[sssd PR#386][-Changes requested] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

Label: -Changes requested

[sssd PR#386][+Pushed] intg: prevent "TypeError: must be type, not classobj"

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"

Label: +Pushed