URL: https://github.com/SSSD/sssd/pull/620 Author: abbra Title: #620: Add pam_cert_pam_services option Action: opened
PR body: """ Allow customizing which PAM services are allowed to perform smartcard authentication.
Fixes: https://pagure.io/SSSD/sssd/issue/3775
"""
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/620/head:pr620 git checkout pr620
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-406550776
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-406550777
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
fidencio commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-406566714
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
fidencio commented: """ @abbra, patch looks good to me. I'd also provide a scratch-build to Orion in order to be sure it works for him.
In any case, if it's not urgent I'd also like to have either @jhrozek's or @sumit-bose's eyes on this PR. """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-406582898
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
sumit-bose commented: """ Hi Alexander,
thank you for the patch. There is an old patch by @lslebodn which tries to solve the same issue at https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted....
I'd like to ask you if you can use the '+service' '-service' scheme as well because imo it would make the configuration easier to write and read and less error-prone.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-410986217
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
sumit-bose commented: """ @lslebodn created a PR with his old patch at https://pagure.io/SSSD/sssd/pull-request/3799.
@abbra, would you agree that the +- style makes the configuration easier or do you see advantages to always specify the full list? """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411336958
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
abbra commented: """ I think +service style is better. Sorry for slow answers, I'm at the conference this week. """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411373283
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
abbra commented: """ I'm also fine with @lslebodn patch """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411374966
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
fidencio commented: """ @sumit-bose, shall we go for @lslebodn's patch instead? If so, I'd close this PR and push https://pagure.io/SSSD/sssd/pull-request/3799 Tomorrow. """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411871939
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
sumit-bose commented: """ @fidencio, yes, I'm currently reviewing @lslebodn patch. """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411987368
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
fidencio commented: """ @lslebodn's patch has been merged, thus I'm closing this PR. """
See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-412535140
URL: https://github.com/SSSD/sssd/pull/620 Author: abbra Title: #620: Add pam_cert_pam_services option Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/620/head:pr620 git checkout pr620
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option
Label: +superseded
sssd-devel@lists.fedorahosted.org