[sssd PR#897][opened] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Author: pbrezina
 Title: #897: db: fix potential memory leak in sysdb_store_selinux_config
Action: opened

PR body:
"""
None
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/897/head:pr897
git checkout pr897

[sssd PR#897][+Waiting for review] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

Label: +Waiting for review

[sssd PR#897][comment] db: fix potential memory leak in sysdb_store_selinux_config

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

alexey-tikhonov commented:
"""
Nitpick:
IMO, it would be slightly better performance-wise to simply move
```
if (!order) {
    DEBUG(SSSDBG_CRIT_FAILURE, "The SELinux order is missing\n");
    return EINVAL;
}
```
above `attrs = talloc_zero` thus avoiding redundant alloc/free in case of missing `order`.

But patch "as is" obviously fixes memleak. So if you do not want to address this remark then ACK and feel free to push this.
"""

See the full comment at https://github.com/SSSD/sssd/pull/897#issuecomment-541085121

[sssd PR#897][-Waiting for review] db: fix potential memory leak in sysdb_store_selinux_config

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

Label: -Waiting for review

[sssd PR#897][comment] db: fix potential memory leak in sysdb_store_selinux_config

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

alexey-tikhonov commented:
"""
Covscan is fine as well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/897#issuecomment-541087953

[sssd PR#897][synchronized] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Author: pbrezina
 Title: #897: db: fix potential memory leak in sysdb_store_selinux_config
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/897/head:pr897
git checkout pr897

[sssd PR#897][comment] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

pbrezina commented:
"""
Thank you for your review. I changed to code as you suggested.
"""

See the full comment at https://github.com/SSSD/sssd/pull/897#issuecomment-541605400

[sssd PR#897][comment] db: fix potential memory leak in sysdb_store_selinux_config

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

alexey-tikhonov commented:
"""
> I changed to code as you suggested.

Thank you. Just running covscan again...

"""

See the full comment at https://github.com/SSSD/sssd/pull/897#issuecomment-541608072

[sssd PR#897][comment] db: fix potential memory leak in sysdb_store_selinux_config

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

alexey-tikhonov commented:
"""
> Thank you. Just running covscan again...

Done.

"""

See the full comment at https://github.com/SSSD/sssd/pull/897#issuecomment-541667380

[sssd PR#897][+Accepted] db: fix potential memory leak in sysdb_store_selinux_config

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

Label: +Accepted

[sssd PR#897][+Ready to push] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

Label: +Ready to push

[sssd PR#897][comment] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

pbrezina commented:
"""
* `master`
    * 50cf3849c508b37eb908f4183ce809c18c9482fd - db: fix potential memory leak in sysdb_store_selinux_config

"""

See the full comment at https://github.com/SSSD/sssd/pull/897#issuecomment-542119502

[sssd PR#897][+Pushed] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

Label: +Pushed

[sssd PR#897][-Accepted] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

Label: -Accepted

[sssd PR#897][-Ready to push] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Title: #897: db: fix potential memory leak in sysdb_store_selinux_config

Label: -Ready to push

[sssd PR#897][closed] db: fix potential memory leak in sysdb_store_selinux_config

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/897
Author: pbrezina
 Title: #897: db: fix potential memory leak in sysdb_store_selinux_config
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/897/head:pr897
git checkout pr897