[sssd PR#5272][opened] WIP! responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM
URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: WIP! responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM Action: opened
PR body: """ This is work in progress!
There was a mismatch between the information provided by NSS and IFP interfaces. nss_protocol_fill_initgr() returned SYSDB_PRIMARY_GROUP_GIDNUM, but GetUserGroups() didn't. This commit makes GetUserGroups() also return SYSDB_PRIMARY_GROUP_GIDNUM value.
Resolves: https://github.com/SSSD/sssd/issues/4569 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5272/head:pr5272 git checkout pr5272
URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: WIP! responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5272/head:pr5272 git checkout pr5272
URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: WIP! responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5272/head:pr5272 git checkout pr5272
URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber Action: edited
Changed field: title Original value: """ WIP! responder_utils: GetUserGroups() returns SYSDB_PRIMARY_GROUP_GIDNUM """
URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber Action: edited
Changed field: body Original value: """ This is work in progress!
There was a mismatch between the information provided by NSS and IFP interfaces. nss_protocol_fill_initgr() returned SYSDB_PRIMARY_GROUP_GIDNUM, but GetUserGroups() didn't. This commit makes GetUserGroups() also return SYSDB_PRIMARY_GROUP_GIDNUM value.
Resolves: https://github.com/SSSD/sssd/issues/4569 """
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5272/head:pr5272 git checkout pr5272
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
ikerexxe commented: """ CI failures are not related with the change itself. """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-688364832
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
sumit-bose commented: """ Hi,
thanks for the patch and your patience. I tested the patch and it worked as expected but please see my inline comment.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-701253805
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5272/head:pr5272 git checkout pr5272
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
sumit-bose commented: """ Hi,
thank you, I have no further comments, the CI failure on F32 seems unrelated. ACK.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-701391038
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
ikerexxe commented: """ Thank you for having a look at it. I was already doing it but I was unable to find any connection between my changes and the failure. """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-701395254
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
sumit-bose commented: """
Thank you for having a look at it. I was already doing it but I was unable to find any connection between my changes and the failure.
The issue can be seen in other CI runs as well, currently I have no idea for the reason. """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-701405851
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
alexey-tikhonov commented: """
Thank you for having a look at it. I was already doing it but I was unable to find any connection between my changes and the failure.
The issue can be seen in other CI runs as well, currently I have no idea for the reason.
It fails with ``` FAILED test_session_recording.py::test_none - AssertionError: list mismatch: ```
@justin-stephenson , could you please take a look? """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-701412264
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
justin-stephenson commented: """
Thank you for having a look at it. I was already doing it but I was unable to find any connection between my changes and the failure.
The issue can be seen in other CI runs as well, currently I have no idea for the reason.
It fails with
FAILED test_session_recording.py::test_none - AssertionError: list mismatch:@justin-stephenson , could you please take a look?
Yes, let me do some investigation """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-701422258
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
justin-stephenson commented: """ This **test_session_recording.py::test_none** runs successfully on my Fedora 32 system. I tried to execute the CI tests following https://github.com/SSSD/sssd/blob/master/contrib/test-suite/README.md using `sssd-vagrant/fedora32-client` in the `config.json` but it fails here: ~~~ [sssd-test-suite] [tesẗ́-suite] [3/5] Running ./contrib/ci/run pep8: failure 00:00:03 ci-pep8.log FAILURE [sssd-test-suite] [tesẗ́-suite] ERROR ShellCommandError: Command returned non-zero status code: 1 [sssd-test-suite] [tesẗ́-suite] [4/5] Archive artifacts (skipped on error) [sssd-test-suite] [tesẗ́-suite] [5/5] Halting guests: ['client'] (finalizing) ==> client: Halting domain... ~~~
Is there something I'm missing to execute the tests the same way as the CI is running them(in order to reproduce the failure)? """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-701454605
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
pbrezina commented: """ Please ping me or IRC or on e-mail (or on the team list) and I'll help you with it. """
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-702058453
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5272
* `master` * 5ddabede92500b7c7b64405bff632484be826aac - IFP-TESTS: GetUserGroups() returns origPrimaryGroupGidNumber * 49481da2fd269975066c4661ddad5e448085c469 - IFP: GetUserGroups() returns origPrimaryGroupGidNumber
"""
See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-702058956
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5272 Author: ikerexxe Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5272/head:pr5272 git checkout pr5272
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
ikerexxe
-
justin-stephenson
-
pbrezina
-
sumit-bose