URL: https://github.com/SSSD/sssd/pull/976 Author: pbrezina Title: #976: ad gpo: use ndr_pull_steal_switch_value Action: opened
PR body: """ Newest samba (samba-devel-4.12.0-0.0.rc1) removed `ndr_pull_get_switch_value` [1]. This function is replaced with `ndr_pull_steal_switch_value` in samba code [2]. Because it also changed the signature of `ndr_pull_steal_switch_value` we need to keep using `ndr_pull_get_switch_value` in older systems [3].
[1] https://gitlab.com/samba-team/samba/commit/9018c7f112c105fb37fb18109b7fe93b4... [2] https://gitlab.com/samba-team/samba/commit/e5162a4d1cff265ac1425e71f4833a7ff... [3] https://gitlab.com/samba-team/samba/commit/263269ba6f75a36676546823b0be1bddd... """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/976/head:pr976 git checkout pr976
URL: https://github.com/SSSD/sssd/pull/976 Author: pbrezina Title: #976: ad gpo: use ndr_pull_steal_switch_value Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/976/head:pr976 git checkout pr976
URL: https://github.com/SSSD/sssd/pull/976 Author: pbrezina Title: #976: [wip] ad gpo: use ndr_pull_steal_switch_value Action: edited
Changed field: title Original value: """ ad gpo: use ndr_pull_steal_switch_value """
URL: https://github.com/SSSD/sssd/pull/976 Title: #976: [wip] ad gpo: use ndr_pull_steal_switch_value
pbrezina commented: """ Just switching the functions does not work correctly, I will have to look into the code and actually see what it does to fix it.
Also there seems to be a memory leak in dlopen on rawhide so that is why the tests fails. I opened https://bugzilla.redhat.com/show_bug.cgi?id=1796433 """
See the full comment at https://github.com/SSSD/sssd/pull/976#issuecomment-580231973
URL: https://github.com/SSSD/sssd/pull/976 Title: #976: [wip] ad gpo: use ndr_pull_steal_switch_value
pbrezina commented: """ I'm closing this in favor of https://github.com/SSSD/sssd/pull/972, since it is much simpler. """
See the full comment at https://github.com/SSSD/sssd/pull/976#issuecomment-582370953
URL: https://github.com/SSSD/sssd/pull/976 Author: pbrezina Title: #976: [wip] ad gpo: use ndr_pull_steal_switch_value Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/976/head:pr976 git checkout pr976
URL: https://github.com/SSSD/sssd/pull/976 Title: #976: [wip] ad gpo: use ndr_pull_steal_switch_value
Label: +superseded
sssd-devel@lists.fedorahosted.org
-
pbrezina