9:31 a.m.
URL: https://github.com/SSSD/sssd/pull/890
Author: alexey-tikhonov
Title: #890: providers/ipa/: add_v1_user_data() amended
Action: opened
PR body:
"""
Fixes few mistypes and compilation warning:
```
sssd-2.2.3/src/providers/ipa/ipa_s2n_exop.c:665:20: warning: 'gc' may be used
uninitialized in this function [-Wmaybe-uninitialized]
attrs->ngroups = gc;
~~~~~~~~~~~~~~~^~~~
```
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/890/head:pr890
git checkout pr890
9:33 a.m.
New subject: [sssd PR#890][+Waiting for review] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
Label: +Waiting for review
9:36 a.m.
New subject: [sssd PR#890][+branch: sssd-1-16] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
Label: +branch: sssd-1-16
4:05 a.m.
New subject: [sssd PR#890][comment] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
sumit-bose commented:
"""
Hi @alexey-tikhonov,
thanks for the fix, can you add `Related to https://pagure.io/SSSD/sssd/issue/4078` to the
commit message and apply the patch to the master branch instead, so that it can be
backported to sssd-1.16 (instead of being ported forward)?.
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/890#issuecomment-534016649
8:29 a.m.
New subject: [sssd PR#890][synchronized] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Author: alexey-tikhonov
Title: #890: providers/ipa/: add_v1_user_data() amended
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/890/head:pr890
git checkout pr890
8:39 a.m.
New subject: [sssd PR#890][comment] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
alexey-tikhonov commented:
"""
can you add `Related to https://pagure.io/SSSD/sssd/issue/4078` to
the commit message
Done.
and apply the patch to the master branch instead, so that it can be
backported to sssd-1.16 (instead of being ported forward)?.
Not sure I understand this part. PR is against master.
May be I misused `branch: sssd-1-16` label. I meant this PR should be back-ported to 1-16
as well (without separate PR)
"""
See the full comment at https://github.com/SSSD/sssd/pull/890#issuecomment-534103251
10:55 a.m.
New subject: [sssd PR#890][comment] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
sumit-bose commented:
"""
May be I misused `branch: sssd-1-16` label. I meant this PR should be
back-ported to 1-16 as well (without separate PR)
Sorry, this misunderstanding was on my side. All is fine. ACK
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/890#issuecomment-534163704
10:55 a.m.
New subject: [sssd PR#890][-Waiting for review] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
Label: -Waiting for review
10:55 a.m.
New subject: [sssd PR#890][+Accepted] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
Label: +Accepted
3:26 a.m.
New subject: [sssd PR#890][+Ready to push] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
Label: +Ready to push
3:40 a.m.
New subject: [sssd PR#890][comment] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
pbrezina commented:
"""
* `master`
* 39e16cca441d4a6b3affe8f27372c26ed11ac81f - providers/ipa/: add_v1_user_data()
amended
* `sssd-1-16`
* e294f7351b810ea9180b2e9e0cab47beab18ae25 - providers/ipa/: add_v1_user_data()
amended
"""
See the full comment at https://github.com/SSSD/sssd/pull/890#issuecomment-535403036
3:40 a.m.
New subject: [sssd PR#890][+Pushed] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
Label: +Pushed
3:40 a.m.
New subject: [sssd PR#890][-Accepted] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
Label: -Accepted
3:40 a.m.
New subject: [sssd PR#890][-Ready to push] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Title: #890: providers/ipa/: add_v1_user_data() amended
Label: -Ready to push
3:40 a.m.
New subject: [sssd PR#890][closed] providers/ipa/: add_v1_user_data() amended
URL: https://github.com/SSSD/sssd/pull/890
Author: alexey-tikhonov
Title: #890: providers/ipa/: add_v1_user_data() amended
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/890/head:pr890
git checkout pr890
1674
days inactive
1680
days old
sssd-devel@lists.fedorahosted.org
14 comments
3 participants
participants (3)
-
alexey-tikhonov -
pbrezina
-
sumit-bose