URL: https://github.com/SSSD/sssd/pull/864 Author: scabrero Title: #864: Monitor resolv.conf symlink Action: opened
PR body: """ If resolv.conf is a symlink and sssd starts before getting an address from dhcp the data provider will remain forever offline, as the watched parent directory is the directory containing the symlink. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/864/head:pr864 git checkout pr864
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/864#issuecomment-521323491
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
pbrezina commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/864#issuecomment-522970593
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
sumit-bose commented: """ Hi @scabrero ,
thank you for the patches. I think they are important to fix various race-conditions during system boot. I added two comments to the code and will set 'Change Requested' to indicate that I'd like to hear if you agree with my comments and not to say that you should change the code immediately.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/864#issuecomment-524281518
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
scabrero commented: """ Hi Sumit,
thank yoy for your review. I am on holidays until September 2nd, I will have a look when I will return.
Cheers.
On Fri, Aug 23, 2019 at 04:31:36AM -0700, sumit-bose wrote:
Hi @scabrero ,
thank you for the patches. I think they are important to fix various race-conditions during system boot. I added two comments to the code and will set 'Change Requested' to indicate that I'd like to hear if you agree with my comments and not to say that you should change the code immediately.
bye, Sumit
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SSSD/sssd/pull/864#issuecomment-524281518
"""
See the full comment at https://github.com/SSSD/sssd/pull/864#issuecomment-524462705
URL: https://github.com/SSSD/sssd/pull/864 Author: scabrero Title: #864: Monitor resolv.conf symlink Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/864/head:pr864 git checkout pr864
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
scabrero commented: """ Hi,
is anything required on my side to push this forward?
Thanks. """
See the full comment at https://github.com/SSSD/sssd/pull/864#issuecomment-541313568
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
sumit-bose commented: """ Hi,
it took me a bit longer than expected to test the patches because it looks like there are some build issues in the current SSSD tree if inotify is not available. I'll try to fix this in a different PR. Nevertheless the patches are working as expected and neither I nor Coverity have some issues with the code. ACK
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/864#issuecomment-542297183
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
pbrezina commented: """ * `master` * d57c67e4efc64a16b874b46eb9670fdc9c73a39f - MONITOR: Resolve symlinks setting the inotify watchers * 9b6323d8e99c3edb16b64ef60a769efbc3a292aa - MONITOR: Add a new option to control resolv.conf monitoring * d20a7f9d5e56d1e9af273d97c7fd42fe8b2eda47 - MONITOR: Propagate error when resolv.conf does not exists in polling mode
"""
See the full comment at https://github.com/SSSD/sssd/pull/864#issuecomment-543174400
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/864 Title: #864: Monitor resolv.conf symlink
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/864 Author: scabrero Title: #864: Monitor resolv.conf symlink Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/864/head:pr864 git checkout pr864
sssd-devel@lists.fedorahosted.org
-
centos-ci -
pbrezina
-
scabrero
-
sumit-bose