[PATCH] 1332-Abort unit test when open() fails‏

[Ariel Barria]

https://fedorahosted.org/sssd/ticket/1332

[Stephen Gallagher]

On Tue, 2012-05-15 at 06:22 -0500, Ariel Barria wrote:
> https://fedorahosted.org/sssd/ticket/1332

I don't think this is actually our bug. The 'check' unit test framework
should not ever be progressing past a failed assertion. I checked their
unreleased upstream code and this has been identified and fixed there. I
opened https://bugzilla.redhat.com/show_bug.cgi?id=821933 to include
this fix in the Fedora release. I provided the upstream patch, so we
should hopefully see it incorporated soon.

As such, I'm inclined to close this ticket as "wontfix", since it will
be addressed in 'check' instead.

Sorry for wasting your time, Ariel. I'm sure we can find some other bugs
for you to work on if you're interested, though.

[Ariel Barria]

no problem stephen , I lost no time, I've learned to make unit test in c with "check framework" :)

"I'm sure we can find some other bugs for you to work on if you're interested" yes, I'm interested. thanks.

From: [e-mail]
To: [e-mail]
Date: Tue, 15 May 2012 15:17:26 -0400
Subject: Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails‏

On Tue, 2012-05-15 at 06:22 -0500, Ariel Barria wrote:
> https://fedorahosted.org/sssd/ticket/1332

I don't think this is actually our bug. The 'check' unit test framework
should not ever be progressing past a failed assertion. I checked their
unreleased upstream code and this has been identified and fixed there. I
opened https://bugzilla.redhat.com/show_bug.cgi?id=821933 to include
this fix in the Fedora release. I provided the upstream patch, so we
should hopefully see it incorporated soon.

As such, I'm inclined to close this ticket as "wontfix", since it will
be addressed in 'check' instead.

Sorry for wasting your time, Ariel. I'm sure we can find some other bugs
for you to work on if you're interested, though.

_______________________________________________
sssd-devel mailing list
[e-mail]
https://fedorahosted.org/mailman/listinfo/sssd-devel

[Stephen Gallagher]

On Tue, 2012-05-15 at 14:53 -0500, Ariel Barria wrote:
> no problem stephen , I lost no time, I've learned to make unit test in
> c with "check framework" :)
>
> "I'm sure we can find some other bugs for you to work on if you're interested"
>  yes, I'm interested. thanks.

You might want to give https://fedorahosted.org/sssd/ticket/1213 a look.
That should be reasonably straightforward, but it'll help you get a bit
more familiar with some of the LDAP code.

[Ariel Barria]

apology, this is in ldap_common.c? or i'm wrong

From: [e-mail]
To: [e-mail]
Date: Tue, 15 May 2012 16:01:18 -0400
Subject: Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails‏

On Tue, 2012-05-15 at 14:53 -0500, Ariel Barria wrote:
> no problem stephen , I lost no time, I've learned to make unit test in
> c with "check framework" :)
>
> "I'm sure we can find some other bugs for you to work on if you're interested"
>  yes, I'm interested. thanks.

You might want to give https://fedorahosted.org/sssd/ticket/1213 a look.
That should be reasonably straightforward, but it'll help you get a bit
more familiar with some of the LDAP code.

_______________________________________________
sssd-devel mailing list
[e-mail]
https://fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Wed, May 16, 2012 at 12:43:30AM -0500, Ariel Barria wrote:
> apology, this is in ldap_common.c? or i'm wrong

I haven't really given it that much though but I think the warning
should be either in sdap_deref_search_recv() or maybe in
sdap_deref_search_done().

When you read the dereference code, I'm sure you'll come with your own
opinion on the matter :-)