[sssd PR#5600][opened] SSSD Log: log_bad_address_msg_modification

List overview All Threads
Download

newer

older

[sssd PR#5663][opened] cache_req:...

[sssd PR#5681][opened] Test: sudo...

DeepakDas7

23 Apr 2021 23 Apr '21

1:08 a.m.

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: opened

PR body: """ Improve Log Containing Bad Address string

Resolves: https://github.com/SSSD/sssd/issues/5577 """

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

Attachments:

sssd-pr-5600.patch (text/x-diff — 3.0 KB)

Show replies by date

DeepakDas7

25 Apr 25 Apr

7:27 a.m.

New subject: [sssd PR#5600][synchronized] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

DeepakDas7

7:29 a.m.

New subject: [sssd PR#5600][synchronized] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

ikerexxe

28 Apr 28 Apr

5:05 a.m.

New subject: [sssd PR#5600][+Waiting for review] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Waiting for review

ikerexxe

5:05 a.m.

New subject: [sssd PR#5600][+Bugzilla] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Bugzilla

ikerexxe

5:05 a.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

ikerexxe commented: """ @elkoniu can you take a look at it? """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-828330624

DeepakDas7

29 Apr 29 Apr

9:34 a.m.

New subject: [sssd PR#5600][synchronized] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

elkoniu

4 May 4 May

6:40 a.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

elkoniu commented: """ @ikerexxe Sorry for the delay, have this PR on my review list for this week. """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-831876660

elkoniu

8:08 a.m.

New subject: [sssd PR#5600][-Waiting for review] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: -Waiting for review

elkoniu

8:08 a.m.

New subject: [sssd PR#5600][+Changes requested] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Changes requested

elkoniu

9:30 a.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

elkoniu commented: """ I think that when error occurs we should check if we have access to server name and print it always if available rather than making this decision on top of `ret` variable value (`result == EFAULT || result == EIO || result == EPERM)`). """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-831987182

DeepakDas7

9 May 9 May

2:42 a.m.

New subject: [sssd PR#5600][synchronized] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

alexey-tikhonov

10 May 10 May

6:01 a.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

alexey-tikhonov commented: """ It seems those patches break at least one of existing "multihost" tests: https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5600/6/fedora33/multihost-p...

I don't say patches are wrong, but at least tests should be updated as well. """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-836555516

ikerexxe

7:42 a.m.

New subject: [sssd PR#5600][edited] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification Action: edited

Changed field: title Original value: """ SSSD Log: log_bad_address_msg_modification """

elkoniu

17 May 17 May

6:24 p.m.

New subject: [sssd PR#5600][comment] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification

elkoniu commented: """ @DeepakDas7 as we discussed on IRC ping me any time this PR will be ready for review :) """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-842707488

DeepakDas7

8 Jun 8 Jun

10:16 a.m.

New subject: [sssd PR#5600][synchronized] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

DeepakDas7

9 Jun 9 Jun

4:37 a.m.

New subject: [sssd PR#5600][synchronized] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

DeepakDas7

5:09 a.m.

New subject: [sssd PR#5600][synchronized] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

DeepakDas7

9:10 a.m.

New subject: [sssd PR#5600][synchronized] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

ikerexxe

10 Jun 10 Jun

3:40 a.m.

New subject: [sssd PR#5600][+Waiting for review] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification

Label: +Waiting for review

ikerexxe

3:40 a.m.

New subject: [sssd PR#5600][-Changes requested] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification

Label: -Changes requested

alexey-tikhonov

15 Jun 15 Jun

10:46 a.m.

New subject: [sssd PR#5600][comment] [WIP] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: [WIP] SSSD Log: log_bad_address_msg_modification

alexey-tikhonov commented: """ Hi @DeepakDas7, why is this still [WIP]? """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-861612924

ikerexxe

17 Jun 17 Jun

5:52 a.m.

New subject: [sssd PR#5600][edited] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: edited

Changed field: title Original value: """ [WIP] SSSD Log: log_bad_address_msg_modification """

DeepakDas7

19 Jun 19 Jun

12:59 p.m.

New subject: [sssd PR#5600][synchronized] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

DeepakDas7

21 Jun 21 Jun

8:52 a.m.

New subject: [sssd PR#5600][synchronized] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

elkoniu

11:08 a.m.

New subject: [sssd PR#5600][-Waiting for review] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: -Waiting for review

elkoniu

11:08 a.m.

New subject: [sssd PR#5600][+Accepted] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Accepted

ikerexxe

22 Jun 22 Jun

1:55 a.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

ikerexxe commented: """ I've reviewed the tests that are failing and there seems to be a timeout error that seems to be related with the infrastructure. @elkoniu do you think we should relaunch the tests? Or are you comfortable with the actual results? """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-865648943

elkoniu

7:18 a.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

elkoniu commented: """ @ikerexxe I just triggered test run again, lets wait for the results and decide then. """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-865934826

elkoniu

23 Jun 23 Jun

8:29 a.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

elkoniu commented: """ @DeepakDas7 can you rebase this to latest master? """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-866836691

DeepakDas7

24 Jun 24 Jun

11:46 a.m.

New subject: [sssd PR#5600][synchronized] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

elkoniu

6:08 p.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

elkoniu commented: """ @pbrezina It looks like this is the merge candidate. """

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-868017752

pbrezina

8 Jul 8 Jul

4:27 a.m.

New subject: [sssd PR#5600][+Ready to push] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Ready to push

pbrezina

4:30 a.m.

New subject: [sssd PR#5600][comment] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5600

* `master` * 7646ac958da5d0f3997c7655e39f7a2f43d6ec1f - SSSD Log: log_bad_address_msg_mod

"""

See the full comment at https://github.com/SSSD/sssd/pull/5600#issuecomment-876286351

pbrezina

4:30 a.m.

New subject: [sssd PR#5600][+Pushed] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: +Pushed

pbrezina

4:30 a.m.

New subject: [sssd PR#5600][-Accepted] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: -Accepted

pbrezina

4:30 a.m.

New subject: [sssd PR#5600][-Ready to push] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Title: #5600: SSSD Log: log_bad_address_msg_modification

Label: -Ready to push

pbrezina

4:30 a.m.

New subject: [sssd PR#5600][closed] SSSD Log: log_bad_address_msg_modification

URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: closed

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600

1837

Age (days ago)

1913

Last active (days ago)

sssd-devel@lists.fedorahosted.org

37 comments

5 participants

tags (0)

participants (5)

alexey-tikhonov
DeepakDas7
elkoniu
ikerexxe
pbrezina