URL: https://github.com/SSSD/sssd/pull/290 Author: lslebodn Title: #290: SECRETS: Fix warning Wpointer-bool-conversion Action: opened
PR body: """ I was playing with clang after a longer period and found this issue
Debug messages would always say that verify_peer and verify_host are enabled. Even though they would be explicitly disabled.
src/responder/secrets/proxy.c:143:18: error: address of 'cfg->verify_peer' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] (&cfg->verify_peer ? "true" : "false")); ~~~~~^~~~~~~~~~~ ~ src/util/debug.h:108:32: note: expanded from macro 'DEBUG' format, ##__VA_ARGS__); \ ^~~~~~~~~~~ src/responder/secrets/proxy.c:149:18: error: address of 'cfg->verify_host' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] (&cfg->verify_host ? "true" : "false")); ~~~~~^~~~~~~~~~~ ~ src/util/debug.h:108:32: note: expanded from macro 'DEBUG' format, ##__VA_ARGS__); \ ^~~~~~~~~~~ """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/290/head:pr290 git checkout pr290
URL: https://github.com/SSSD/sssd/pull/290 Title: #290: SECRETS: Fix warning Wpointer-bool-conversion
jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/70/60/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/290#issuecomment-304897687
URL: https://github.com/SSSD/sssd/pull/290 Title: #290: SECRETS: Fix warning Wpointer-bool-conversion
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/290 Author: lslebodn Title: #290: SECRETS: Fix warning Wpointer-bool-conversion Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/290/head:pr290 git checkout pr290
URL: https://github.com/SSSD/sssd/pull/290 Title: #290: SECRETS: Fix warning Wpointer-bool-conversion
lslebodn commented: """ master: * 074ded4cda2ce88563a3e7e5cc0eea808d3322b3 """
See the full comment at https://github.com/SSSD/sssd/pull/290#issuecomment-305185062
URL: https://github.com/SSSD/sssd/pull/290 Title: #290: SECRETS: Fix warning Wpointer-bool-conversion
Label: +Pushed
sssd-devel@lists.fedorahosted.org